Skip to content

Duplicate identifier errors when compiling a project which links a module #474

Closed

Description

@SamVerschueren

Describe your environment

  • Operating System version: macOS Sierra
  • Firebase SDK version: 4.9.0
  • Firebase Product: auth, database

Describe the problem

We are using a monorepo and have a module (A) which depends on another module (B). Both of firebase listed as dependency. Compiling module B is not a problem. Compiling module A however is. These errors are showing up:

screen shot 2018-01-28 at 19 19 31

I tweeted about this, and @DanielRosenwasser replied that it should be fixed in here. https://twitter.com/drosenwasser/status/957872358978609152

I was able to solve it with paths mappings in tsconfig.json, but would be nice if it just worked without.

Steps to reproduce:

  1. Create 2 modules which both have firebase as dependency
  2. Link one module to the other yarn add link:../module-b
  3. Compile

(Better to look at the reproduction repository)

Relevant Code:

Here's the repository I created to reproduce the problem. https://github.com/SamVerschueren/firebase-duplicate-tsd

// @jshcrowthe

Activity

  1. google-oss-bot commented on Jan 30, 2018

    @google-oss-bot
    Collaborator

    Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

  2. self-assigned this
    on Jan 30, 2018
  3. 0x-r4bbit commented on Mar 28, 2018

    @0x-r4bbit

    I can confirm this issue. This a problem that exists with firebase version 4.9.0+.

  4. 0x-r4bbit commented on Apr 3, 2018

    @0x-r4bbit

    🎉

  5. locked and limited conversation to collaborators on Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址