Repository navigation
Fix SigNoz cache span filtering - #2479
Merged
Merged
Conversation
ejsmith
force-pushed
the
issue/fix-signoz-cache-span-filter
branch
from
August 17, 2026 15:41
197ce3a to
28a2bc8
Compare
ejsmith
marked this pull request as ready for review
August 28, 2026 02:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db.systemand the newerdb.system.namesemantic-convention attribute.STATUS_CODE_ERRORand retain the existingMessage: EntityChangedfilter.Root cause
The cache-span filter was scoped to two fixed
service.namevalues. A deployment renamed a service, so its successful Redis spans stopped matching the filter and were exported to SigNoz.Validation
git diff --checksignoz/k8s-infrachart0.16.0withhelm templateand confirmedfilter/drop_cache_spansis present in the node-agent traces pipeline after chart-injected processors and beforebatch.Breaking changes
None.