Repository navigation
Send Intercom JWT with secured updates - #2461
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intercom_user_jwtwith every identified Intercom SPA update.Why
Messenger Security rejects identified user updates that omit both
user_hashandintercom_user_jwt. The initial boot contained the JWT, but our update helper only resent the JWT when its value changed. Route updates therefore always sentuser_idwithout authentication, producing403 Forbiddenresponses while users navigated the Svelte SPA.Intercom documents
intercom_user_jwtas the field used to identify and update secured Messenger users: https://www.intercom.com/help/en/articles/10589769-authenticating-users-in-the-messenger-with-json-web-tokens-jwtsImpact
Secured Intercom updates remain authenticated while navigating or refreshing user/company data. No API contract or legacy Angular behavior changes.
Verification
npm run test:unit -- --run src/lib/features/intercom/updates.test.ts src/lib/features/intercom/intercom-shell.svelte.test.tsnpm run validatenpm run buildBreaking changes
None.