Repository navigation
ExceptionlessTarget - ApiKey and ServerUrl and Message and UserIdentity with Layout support - #299
Merged
Merged
Conversation
This was referenced Apr 15, 2023
…entity and ReferenceId with Layout support
niemyjski
reviewed
Apr 17, 2023
niemyjski
left a comment
Member
There was a problem hiding this comment.
I left a comment. I don't think we can use reference id's like this because they will be discarded events server side as each event needs to be unique, can you please confirm.
Member
@ejsmith may want to consider bringing correlation id in as it may help track down issues in otel. I'm not sure how well our event references we store in extended data for this scenario would help. |
niemyjski
reviewed
Apr 18, 2023
niemyjski
left a comment
Member
There was a problem hiding this comment.
Looks great, had a question about target changes
niemyjski
approved these changes
Apr 18, 2023
Member
|
Thanks for the PR!!!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #297 and resolves #296
${aspnet-user-identity} comes from NLog.Web.AspNetCore-nuget-package . See also: https://nlog-project.org/config/?tab=layout-renderers