Skip to content

ExceptionlessTarget - ApiKey and ServerUrl and Message and UserIdentity with Layout support - #299

Merged
niemyjski merged 4 commits into
exceptionless:mainfrom
snakefoot:main
Apr 18, 2023
Merged

niemyjski merged 4 commits into
exceptionless:mainfrom
snakefoot:main

Conversation

@snakefoot

@snakefoot snakefoot commented Apr 15, 2023 •

Copy link
Copy Markdown
Contributor

Resolves #297 and resolves #296

    <target type="Exceptionless, Exceptionless.NLog" name="exceptionless"
            apiKey="API_KEY_HERE"
            userIdentity="${aspnet-user-identity}"
            userIdentityName="${aspnet-user-claim:ClaimTypes.Name}">
      <field name="host" layout="${hostname}" />
      <field name="process" layout="${processname}" />
      <field name="user" layout="${environment-user}" />
    </target>

${aspnet-user-identity} comes from NLog.Web.AspNetCore-nuget-package . See also: https://nlog-project.org/config/?tab=layout-renderers

@CLAassistant

CLAassistant commented Apr 15, 2023 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@snakefoot snakefoot changed the title ExceptionlessTarget - ApiKey and ServerUrl and Message and ReferenceId with Layout support ExceptionlessTarget - ApiKey and ServerUrl and Message and UserIdentity and ReferenceId with Layout support Apr 15, 2023

@niemyjski niemyjski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment. I don't think we can use reference id's like this because they will be discarded events server side as each event needs to be unique, can you please confirm.

@snakefoot snakefoot changed the title ExceptionlessTarget - ApiKey and ServerUrl and Message and UserIdentity and ReferenceId with Layout support ExceptionlessTarget - ApiKey and ServerUrl and Message and UserIdentity with Layout support Apr 17, 2023
@niemyjski

Copy link
Copy Markdown
Member

I left a comment. I don't think we can use reference id's like this because they will be discarded events server side as each event needs to be unique, can you please confirm.

@ejsmith may want to consider bringing correlation id in as it may help track down issues in otel. I'm not sure how well our event references we store in extended data for this scenario would help.

@niemyjski niemyjski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, had a question about target changes

@niemyjski

Copy link
Copy Markdown
Member

Thanks for the PR!!!!!!

@niemyjski niemyjski closed this Apr 18, 2023
@niemyjski niemyjski reopened this Apr 18, 2023
@niemyjski
niemyjski merged commit b7cdc10 into exceptionless:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update NLog ExceptionlessTarget to use Layout for ApiKey and ServerUrl NLog: How can I send user identity?

4 participants

⌂ 换网址