Repository navigation
Skip pattern maching for empty sets - #258
Merged
niemyjski merged 4 commits intoDec 30, 2021
Merged
Conversation
benaadams
marked this pull request as draft
May 10, 2021 04:29
benaadams
marked this pull request as ready for review
May 10, 2021 04:39
niemyjski
approved these changes
Dec 30, 2021
niemyjski
left a comment
niemyjski
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Not sure why I never got notified for this until now. These changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets called a lot with empty sets so can skip that and the
HashSetcreation and usestring[]directly