Skip to content

Add ability to exclude Modules from getting sent with error reports. #238

Closed

Description

@niemyjski

This could be done today by adding a plugin https://github.com/exceptionless/Exceptionless.Net/wiki/Adding-Plugins and inspecting the Error and removing any loaded modules. This would shrink payload sizes as well... This is a customer request.

Activity

  1. ejsmith commented on Oct 5, 2020

    @ejsmith
    Member

    I think what we need to do is add a simpler hook that users can wire into that happens after the plugins have run. It would let you easily modify or cancel events right before they are queued to be sent.

  2. niemyjski commented on Apr 12, 2023

    @niemyjski
    MemberAuthor

    @ejsmith this data is deeply nested on the root error object and not easy to get to? What if we just introduced the pattern where for select properties, we looked at DataExclusions? In this case if Modules is in client.Configuration.DataExclusions we don't populate them?

  3. ejsmith commented on Apr 12, 2023

    @ejsmith
    Member

    I think you can pretty easily disable modules being collected altogether. I think what would be a generally useful feature is if you can see the fully populated event right before it's about to be sent and you could make changes or even decide to cancel sending it all together.

  4. niemyjski commented on Apr 13, 2023

    @niemyjski
    MemberAuthor

    @ejsmith you can do that today with client.OnSubmitting The event is fully processed, and the next line sees if you cancelled it before enqueuing it.

    I was thinking about DataExclusions I kind of feel like that would be magic and cause confusion as to what properties would be taken into account. I think I'd rather just add a flag to the configuration for excluding error module information.

  5. self-assigned this
    on Apr 27, 2023
  6. niemyjski commented on Apr 27, 2023

    @niemyjski
    MemberAuthor

    I'm going to close this, if we feel like we need it let's reopen. It would be nice to trim this from our payloads but it does add value. Also, you can write a plugin or use client.OnSubmitting event handler to remove this data today.

  7. added a commit that references this issue on Apr 27, 2023
    2187560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址