Skip to content

embed: reject domain names before binding - #6365

Merged
heyitsanthony merged 2 commits into
etcd-io:masterfrom
heyitsanthony:fix-dns-bind
Sep 6, 2016
Merged

heyitsanthony merged 2 commits into
etcd-io:masterfrom
heyitsanthony:fix-dns-bind

Conversation

@heyitsanthony

Copy link
Copy Markdown

Fixes #6336

@xiang90

xiang90 commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

lgtm

@heyitsanthony
heyitsanthony merged commit af5ab7b into etcd-io:master Sep 6, 2016
@heyitsanthony
heyitsanthony deleted the fix-dns-bind branch September 6, 2016 23:03
heyitsanthony pushed a commit to heyitsanthony/etcd that referenced this pull request Sep 13, 2016
@richinsr

Copy link
Copy Markdown

FYI, anyone using domain names and upgrading to the published 3.0.8 release will have their cluster break. Thoughts about cutting a new release with the reverted merge included?

@heyitsanthony

Copy link
Copy Markdown
Author

@richinsr the revert will be in 3.0.9 this Friday. How is it breaking the cluster on upgrade? It will only reject the flags starting an upgraded member-- the cluster can stay on 3.0.7 if the 3.0.8 upgrade doesn't take.

@richinsr

Copy link
Copy Markdown

@heyitsanthony I was working on upgrading a cluster today for someone else and the first node that was upgraded to 3.0.8 failed to start given the config uses a domain name for listen-peer-urls. It took a bit to track down this thread to realize that the config is wrong in the fist place (cluster was setup by someone else). If enforcement of not using domain names will be addressed in 3.1 then anyone in my same boat who upgrades to 3.0.8 will encounter a failure but every other release in the 3.0.x family will work. Maybe it is as simple as adding a note to https://github.com/coreos/etcd/blob/master/NEWS

@heyitsanthony

Copy link
Copy Markdown
Author

@richinsr it'll be enforced in 3.2. 3.1 will just have a warning.

gyuho pushed a commit that referenced this pull request Sep 15, 2016
This reverts commit af5ab7b, reversing
changes made to da6a0f0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址