Skip to content

[oracle] Fix used bytes logic - #9951

Merged
niraj-elastic merged 6 commits into
elastic:mainfrom
niraj-elastic:package_oracle_fix_used_bytes
May 29, 2024
Merged

niraj-elastic merged 6 commits into
elastic:mainfrom
niraj-elastic:package_oracle_fix_used_bytes

Conversation

@niraj-elastic

@niraj-elastic niraj-elastic commented May 23, 2024 •

Copy link
Copy Markdown
Contributor

Description

The field oracle.tablespace.space.used.bytes is calculated wrongly

Currently we are showing total bytes of tablespace in integration which seems to be incorrect for the field description. This PR will update this query to do following calculation space.used.bytes = Total bytes - Free Bytes

Also fixed visualization related to total.bytes

In visualization "Table space total size" There are two defrent queries are used for counting total bytes.
For NON-TEMP we are showing used+free which is correct.
unnamed (5)

But for TEPM we are directly showing total bytes. which is incorrect and shows total of all the tablespace.
unnamed (6)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/orecle) directory.
  • Run the following command to run tests. elastic-package test

Related issues

@niraj-elastic
niraj-elastic requested a review from a team as a code owner May 23, 2024 05:29
@niraj-elastic niraj-elastic self-assigned this May 23, 2024
@niraj-elastic
niraj-elastic requested a review from agithomas May 23, 2024 05:38
@niraj-elastic niraj-elastic added Integration:oracle Oracle Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels May 23, 2024
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@niraj-elastic niraj-elastic changed the title Package oracle fix used bytes [oracle] Fix used bytes logic May 23, 2024
@shmsr shmsr added the bug Something isn't working, use only for issues label May 23, 2024
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @niraj-elastic

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ishleenk17

ishleenk17 commented May 27, 2024 •

Copy link
Copy Markdown
Member

@niraj-elastic Can you share the before and after of the dashboard? Are there changes other than label change in dashboard?

@@ -1,3 +0,0 @@
errors:
exclude_checks:
- SVR00002

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More details on this, please.
How is this validation removal being handled in the PR?

@niraj-elastic niraj-elastic May 28, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the datastream.dataset filter is already added to oracle. we don't need to exclude this check. So we can remove this check file.

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niraj-elastic
niraj-elastic requested a review from ishleenk17 May 28, 2024 05:52

@milan-elastic milan-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niraj-elastic

Copy link
Copy Markdown
Contributor Author

@niraj-elastic Can you share the before and after of the dashboard? Are there changes other than label change in dashboard?

@ishleenk17 The labels are added in this PR which is merged now. we have changed one visualization which has total bytes. I have updated the description with more details of change.

@ishleenk17

Copy link
Copy Markdown
Member

@niraj-elastic Can you share the before and after of the dashboard? Are there changes other than label change in dashboard?

@ishleenk17 The labels are added in this PR which is merged now. we have changed one visualization which has total bytes. I have updated the description with more details of change.

Thanks for updating the description. It’s much more informative now.

@niraj-elastic
niraj-elastic merged commit 1dc8e40 into elastic:main May 29, 2024
@elasticmachine

Copy link
Copy Markdown

Package oracle - 1.26.1 containing this change is available at https://epr.elastic.co/search?package=oracle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:oracle Oracle Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Oracle] Field oracle.tablespace.space.used.bytes is calculated wrongly

6 participants

⌂ 换网址