Skip to content

[Oracle] README updates regarding mandatory user permission - #9104

Merged
agithomas merged 5 commits into
elastic:mainfrom
agithomas:ingest-issue-226
Feb 12, 2024
Merged

agithomas merged 5 commits into
elastic:mainfrom
agithomas:ingest-issue-226

Conversation

@agithomas

@agithomas agithomas commented Feb 9, 2024 •

Copy link
Copy Markdown
Contributor
  • Enhancement

Proposed commit message

README updates regarding mandatory user permission.
This helps to assign permissions to Oracle user for configuring Oracle Integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • elastic-package stack up -v -d --services package-registry
  • Manual content verification

How to test this PR locally

elastic-package build
elastic-package stack up -v -d --services package-registry

Related issues

Screenshots

image

@elasticmachine

elasticmachine commented Feb 9, 2024 •

Copy link
Copy Markdown

🚀 Benchmarks report

Package oracle 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
database_audit 25641.03 8264.46 -17376.57 (-67.77%) 💔

To see the full report comment with /test benchmark fullreport

@agithomas
agithomas marked this pull request as ready for review February 9, 2024 08:37
@agithomas
agithomas requested a review from a team as a code owner February 9, 2024 08:37

@alaudazzi alaudazzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few editing suggestions.
Regarding accessible terms, on top of the WCAG 2.0 guidelines it is useful to refer to the Accessibility guidelines developed by the Elastic doc team.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@alaudazzi alaudazzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the permissions required for each of the metrics have been verified, the documentation looks fine.

@agithomas
agithomas merged commit 91fa501 into elastic:main Feb 12, 2024
@elasticmachine

Copy link
Copy Markdown

Package oracle - 1.24.3 containing this change is available at https://epr.elastic.co/search?package=oracle

@agithomas
agithomas deleted the ingest-issue-226 branch February 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document minimum permissions required to run Oracle Metricbeat module or Oracle Integration

5 participants

⌂ 换网址