Skip to content

[zeek] - Modified field definitions to use ECS - #8062

Merged
andrewkroh merged 1 commit into
elastic:mainfrom
andrewkroh:zeek/feature/cleanup-fields-yml
Oct 3, 2023
Merged

andrewkroh merged 1 commit into
elastic:mainfrom
andrewkroh:zeek/feature/cleanup-fields-yml

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Oct 3, 2023 •

Copy link
Copy Markdown
Contributor

Proposed commit message

Modified the field definitions to reference ECS where possible and remove invalid field attributes. By "invalid" I mean these attributes that are allowed in package-spec to avoid a breaking-change but serve no purpose.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20231003061136-3ff9278e0277 \
  -skip-format -fields-yml-use-ecs -fields-yml-cleanup-attrs packages/zeek

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Modified the field definitions to reference ECS where possible and remove
invalid field attributes.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20231003061136-3ff9278e0277 -skip-format -fields-yml-use-ecs -fields-yml-cleanup-attrs packages/zeek
@elasticmachine

elasticmachine commented Oct 3, 2023 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-03T06:18:32.009+0000

  • Duration: 59 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 254
Skipped 0
Total 254

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh added Integration:zeek Zeek enhancement New feature or request labels Oct 3, 2023
@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (43/43) 💚
Files 96.341% (79/82) 👎 -3.659
Classes 96.341% (79/82) 👎 -3.659
Methods 92.021% (692/752) 👍 16.264
Lines 92.055% (8632/9377) 👎 -7.945
Conditionals 100.0% (0/0) 💚

@andrewkroh
andrewkroh marked this pull request as ready for review October 3, 2023 21:08
@andrewkroh
andrewkroh requested a review from a team as a code owner October 3, 2023 21:08
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@andrewkroh
andrewkroh merged commit 70a8199 into elastic:main Oct 3, 2023
@elasticmachine

Copy link
Copy Markdown

Package zeek - 2.18.0 containing this change is available at https://epr.elastic.co/search?package=zeek

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Modified the field definitions to reference ECS where possible and remove
invalid field attributes.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20231003061136-3ff9278e0277 -skip-format -fields-yml-use-ecs -fields-yml-cleanup-attrs packages/zeek
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:zeek Zeek

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址