Skip to content

Enabling GA release for time_series index.mode - #6332

Merged
lalit-satapathy merged 6 commits into
elastic:mainfrom
lalit-satapathy:tsdb_ga_k8_and_nginx
May 29, 2023
Merged

lalit-satapathy merged 6 commits into
elastic:mainfrom
lalit-satapathy:tsdb_ga_k8_and_nginx

Conversation

@lalit-satapathy

Copy link
Copy Markdown
Contributor

We are close to releasing k8 and nginx and the first set of two packages as TSDB GA( in 8.8.0 release). In preparation towards that, creating a draft PR ready.

There is a discussion going on, whether this should be major version change(2.0.0) but not closed yet.

What does this PR do?

Releasing to k8 and nginx as TSDB GA in 8.8 release.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Tests being done and tracked separately

Related issues

Screenshots

Screenshot 2023-05-26 at 11 28 25 AM Screenshot 2023-05-26 at 11 28 35 AM

@lalit-satapathy lalit-satapathy self-assigned this May 26, 2023
@elasticmachine

elasticmachine commented May 26, 2023 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-26T12:53:37.876+0000

  • Duration: 31 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 114
Skipped 0
Total 114

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 26, 2023 •

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -43.75
Classes 50.0% (2/4) 👎 -43.75
Methods 87.179% (102/117) 👎 -1.173
Lines 70.37% (228/324) 👎 -15.555
Conditionals 100.0% (0/0) 💚

@lalit-satapathy

Copy link
Copy Markdown
Contributor Author

There is a discussion going on, whether this should be major version change(2.0.0) but not closed yet.

We are deciding to continue with minor version upgrade for now.

@lalit-satapathy
lalit-satapathy marked this pull request as ready for review May 26, 2023 06:41
@lalit-satapathy
lalit-satapathy requested review from a team as code owners May 26, 2023 06:41
@lalit-satapathy

Copy link
Copy Markdown
Contributor Author

CC: @mlunadia @ruflin @andresrc for any comments.

Comment thread packages/kubernetes/changelog.yml Resolved

@ruflin ruflin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall change LGTM. Left some comments that apply to both packages but I would not block the PR on it.

Nit: I would split it up into 2 PR's so in case if issues with 1 package, easier to link to it

@ruflin ruflin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall change LGTM. Left some comments that apply to both packages but I would not block the PR on it.

Nit: I would split it up into 2 PR's so in case if issues with 1 package, easier to link to it

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.41.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind clarifying what is the naming progression convention for versions? I was under the impression that after 1.40.0-beta you would create 1.40.0.

FYI @gizas

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.. however since there was a discussion(offline) to whether increase major version for this. Lets at-least stick with a minor version increase for now.

@gsantoro gsantoro May 26, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now merged a couple of changes into the kubernetes package.

I now resolved those conflicts for you in this PR. I hope that's ok with you

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that's added as non beta.. hoping that's ok since this PR should follow right after it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding from this comment is that adding a non-beta version after a beta is ok. I'm not sure still what happens with beta versions or what's the naming convention for following beta versions.

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments and suggestions added.

Approved. Change looks good to me.

@lalit-satapathy
lalit-satapathy merged commit 31d3ee4 into elastic:main May 29, 2023
@elasticmachine

Copy link
Copy Markdown

Package kubernetes - 1.41.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@elasticmachine

Copy link
Copy Markdown

Package nginx - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=nginx

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Enabling GA release for time_series index.mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

⌂ 换网址