Repository navigation
Enabling GA release for time_series index.mode - #6332
Conversation
🌐 Coverage report
|
We are deciding to continue with minor version upgrade for now. |
ruflin
left a comment
There was a problem hiding this comment.
Overall change LGTM. Left some comments that apply to both packages but I would not block the PR on it.
Nit: I would split it up into 2 PR's so in case if issues with 1 package, easier to link to it
ruflin
left a comment
There was a problem hiding this comment.
Overall change LGTM. Left some comments that apply to both packages but I would not block the PR on it.
Nit: I would split it up into 2 PR's so in case if issues with 1 package, easier to link to it
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.41.0" | |||
There was a problem hiding this comment.
Do you mind clarifying what is the naming progression convention for versions? I was under the impression that after 1.40.0-beta you would create 1.40.0.
FYI @gizas
There was a problem hiding this comment.
Good question.. however since there was a discussion(offline) to whether increase major version for this. Lets at-least stick with a minor version increase for now.
There was a problem hiding this comment.
I have now merged a couple of changes into the kubernetes package.
I now resolved those conflicts for you in this PR. I hope that's ok with you
There was a problem hiding this comment.
I see that's added as non beta.. hoping that's ok since this PR should follow right after it.
There was a problem hiding this comment.
My understanding from this comment is that adding a non-beta version after a beta is ok. I'm not sure still what happens with beta versions or what's the naming convention for following beta versions.
agithomas
left a comment
There was a problem hiding this comment.
Comments and suggestions added.
Approved. Change looks good to me.
|
Package kubernetes - 1.41.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
|
Package nginx - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=nginx |
* Enabling GA release for time_series index.mode
We are close to releasing k8 and nginx and the first set of two packages as TSDB GA( in 8.8.0 release). In preparation towards that, creating a draft PR ready.
There is a discussion going on, whether this should be major version change(2.0.0) but not closed yet.
What does this PR do?
Releasing to k8 and nginx as TSDB GA in 8.8 release.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Tests being done and tracked separately
Related issues
Screenshots