Skip to content

[CEF] New dashboards, fixes, formatting and dynamic ECS template - #5955

Merged
P1llus merged 5 commits into
elastic:mainfrom
P1llus:package_cef_dashboards
Apr 24, 2023
Merged

P1llus merged 5 commits into
elastic:mainfrom
P1llus:package_cef_dashboards

Conversation

@P1llus

@P1llus P1llus commented Apr 21, 2023 •

Copy link
Copy Markdown
Member

What does this PR do?

This is part of a bigger cleanup that relates to https://github.com/elastic/security-team/issues/5910.

The tasks, when applicable was:

  • Formatting with https://github.com/efd6/fumpt
  • Add dynamic ECS template
  • Update format_version to 2.6.0
  • Update on_failure to include proper event.kind.
  • Update on_failure error message to be more descriptive
  • If system/pipeline tests are missing, add them when possible.
  • If httpjson, does it have drop processor for empty events?
  • Add TCP input support
  • If no dashboards, add them.
  • If dashboards exist, replace with lens when needed, update dashboards if applicable.

The PR looks like it is changing more than it is, because most of them are formatting changes, I have separated the formatting changes into a separate commit to make it easier.

New dashboards:
arcsight1
Arcsight2
host1
host2
network1
network2
Overview1
overview2

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@P1llus P1llus added enhancement New feature or request Team:Security-External Integrations Integration:cef Common Event Format (CEF) labels Apr 21, 2023
@P1llus
P1llus requested a review from a team as a code owner April 21, 2023 12:18
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Apr 21, 2023 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-24T07:46:20.901+0000

  • Duration: 18 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Apr 21, 2023 •

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 95.652% (22/23) 👎 -4.348
Lines 89.662% (451/503) 👍 4.472
Conditionals 100.0% (0/0) 💚

@P1llus
P1llus merged commit 4935e29 into elastic:main Apr 24, 2023
@elasticmachine

Copy link
Copy Markdown

Package cef - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=cef

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…stic#5955)

* New dashboards, format versions, dynamic ECS template, new testdata

* runs fumpt to clean up formatting

* update changelog

* adding tags to pipeline

* adding tags in pipelines, fixing tag iteration in templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cef Common Event Format (CEF)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址