Skip to content

[Oracle] Adding support for more audit log types - #4447

Merged
P1llus merged 2 commits into
elastic:mainfrom
P1llus:package_oracle_audit_additions
Oct 12, 2022
Merged

P1llus merged 2 commits into
elastic:mainfrom
P1llus:package_oracle_audit_additions

Conversation

@P1llus

@P1llus P1llus commented Oct 12, 2022 •

Copy link
Copy Markdown
Member

What does this PR do?

Oracle has both database and object based audit trails. The current package only support objects, this PR adds support for database as well, which is in a slightly different format

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Oct 12, 2022 •

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Oct 12, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-12T12:24:09.570+0000

  • Duration: 16 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.712
Classes 100.0% (1/1) 💚 2.712
Methods 82.759% (24/29) 👎 -7.565
Lines 94.297% (248/263) 👍 2.658
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus
P1llus merged commit 99d7daa into elastic:main Oct 12, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Adding support for more audit logs

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址