Repository navigation
[GCP] Add firestore data_stream - #2704
Merged
28 commits merged intoMar 30, 2022
Merged
28 commits merged into
28 commits merged into
Conversation
ghost
marked this pull request as ready for review
March 16, 2022 17:35
endorama
suggested changes
Mar 17, 2022
endorama
left a comment
Contributor
There was a problem hiding this comment.
Please ensure elastic-package check does not error. I added some minor changes but overall looks good to me and we can merge this as soon as CI is green
6 of 11 tasks
Author
|
/test |
mtojek
reviewed
Mar 18, 2022
mtojek
left a comment
Contributor
There was a problem hiding this comment.
If you need any help from me, let me know, but please resolve first all conflicts :)
ghost
removed request for
a team
March 21, 2022 22:27
endorama
reviewed
Mar 22, 2022
Contributor
There was a problem hiding this comment.
This has been changed and should be:
Suggested change
| variable "project_id" { | |
| variable "gcp_project_id" { |
Contributor
There was a problem hiding this comment.
I noticed this change was not included in 081c2ce, is that done on purpose?
endorama
reviewed
Mar 22, 2022
endorama
reviewed
Mar 22, 2022
endorama
force-pushed
the
gcp-metrics
branch
2 times, most recently
from
March 22, 2022 15:14
8cf80ec to
fe54af3
Compare
Author
|
/test |
2 similar comments
Author
|
/test |
Author
|
/test |
This reverts commit ceea735.
3 of 4 tasks
endorama
pushed a commit
that referenced
this pull request
Jun 7, 2022
endorama
pushed a commit
that referenced
this pull request
Jun 9, 2022
endorama
pushed a commit
that referenced
this pull request
Jul 12, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds firestore datastream.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots