Skip to content

[GCP] Add firestore data_stream - #2704

Merged
28 commits merged into
gcp-metricsfrom
unknown repository
Mar 30, 2022
Merged

28 commits merged into
gcp-metricsfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 16, 2022

Copy link
Copy Markdown

What does this PR do?

Adds firestore datastream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine

elasticmachine commented Feb 16, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-30T13:58:01.738+0000

  • Duration: 20 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 50
Skipped 0
Total 50

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ghost
ghost marked this pull request as ready for review March 16, 2022 17:35

@endorama endorama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure elastic-package check does not error. I added some minor changes but overall looks good to me and we can merge this as soon as CI is green

@ghost

ghost commented Mar 17, 2022

Copy link
Copy Markdown
Author

/test

@ghost
ghost requested review from a team as code owners March 17, 2022 17:01

@mtojek mtojek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need any help from me, let me know, but please resolve first all conflicts :)

@ghost
ghost removed request for a team March 21, 2022 22:27

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been changed and should be:

Suggested change
variable "project_id" {
variable "gcp_project_id" {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this change was not included in 081c2ce, is that done on purpose?

@endorama
endorama force-pushed the gcp-metrics branch 2 times, most recently from 8cf80ec to fe54af3 Compare March 22, 2022 15:14
@ghost

ghost commented Mar 23, 2022

Copy link
Copy Markdown
Author

/test

2 similar comments
@ghost

ghost commented Mar 23, 2022

Copy link
Copy Markdown
Author

/test

@ghost

ghost commented Mar 23, 2022

Copy link
Copy Markdown
Author

/test

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

⌂ 换网址