Skip to content

Container logs: improve default ndjson parser configuration - #2694

Merged
tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:k8s-container-logs-default-ndjson-config
Feb 15, 2022
Merged

tetianakravchenko merged 2 commits into
elastic:mainfrom
tetianakravchenko:k8s-container-logs-default-ndjson-config

Conversation

@tetianakravchenko

Copy link
Copy Markdown
Contributor

Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co

What does this PR do?

Adjust default ndjson parser configuration. Even though this configuration is commented out, I would add it to prevent Error decoding JSON errors in case there are both: json and not json logs in the k8s cluster.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine

elasticmachine commented Feb 14, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-14T16:10:42.472+0000

  • Duration: 36 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 116
Skipped 0
Total 116

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@tetianakravchenko tetianakravchenko self-assigned this Feb 14, 2022
@tetianakravchenko
tetianakravchenko merged commit 0970906 into elastic:main Feb 15, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…2694)

* container logs: improve default ndjson parser configuration

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add pr link

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址