Skip to content

sysdig: fix expression for maximum window length - #21280

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:s7588-sysdig-duration
Sep 17, 2026
Merged

efd6 merged 1 commit into
elastic:mainfrom
efd6:s7588-sysdig-duration

Conversation

@efd6

@efd6 efd6 commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Proposed commit message

sysdig: fix expression for maximum window length

This was not properly converted to an integer. Retain the values as strings
explicitly except during integer operations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Sep 15, 2026
@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:sysdig Sysdig labels Sep 15, 2026
@efd6
efd6 force-pushed the s7588-sysdig-duration branch from 80768e9 to be2eff6 Compare September 15, 2026 20:54
@github-actions

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@efd6
efd6 force-pushed the s7588-sysdig-duration branch from be2eff6 to 9f3b2c3 Compare September 15, 2026 21:10
This was not properly converted to an integer. Retain the values as strings
explicitly except during integer operations.
@efd6
efd6 force-pushed the s7588-sysdig-duration branch from 9f3b2c3 to 0c12fe7 Compare September 15, 2026 21:26
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

Package sysdig 👍(1) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 4807.69 3154.57 -1653.12 (-34.38%) 💔
cspm 3460.21 2923.98 -536.23 (-15.5%) 💔
vulnerability 1672.24 1364.26 -307.98 (-18.42%) 💔

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@efd6
efd6 marked this pull request as ready for review September 15, 2026 21:56
@efd6
efd6 requested review from a team as code owners September 15, 2026 21:56
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@vera-review-bot

Copy link
Copy Markdown
Contributor

🟢 No issues across the latest commits 0c12fe7.

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot - v0.4.1 | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@mergify

mergify Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@efd6
efd6 merged commit 88395bc into elastic:main Sep 17, 2026
9 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package sysdig - 2.5.2 containing this change is available at https://epr.elastic.co/package/sysdig/2.5.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:sysdig Sysdig Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址