Skip to content

[1password] Add dataset filter to Sign-in Attempts hot users dashboard panel - #21050

Merged
sharad-elastic merged 4 commits into
elastic:mainfrom
sharad-elastic:1password-add-dataset-filter
Sep 11, 2026
Merged

sharad-elastic merged 4 commits into
elastic:mainfrom
sharad-elastic:1password-add-dataset-filter

Conversation

@sharad-elastic

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

Proposed commit message

1password: add dataset filter to sign-in attempts hot users panel

The Sign-in Attempts hot users panel counted events from any matching
data source because it lacked a data_stream.dataset filter. Restrict
the panel to 1password.signin_attempts so counts reflect only
1Password sign-in attempt logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@sharad-elastic sharad-elastic self-assigned this Sep 3, 2026
@sharad-elastic sharad-elastic added Integration:1password 1Password Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Sep 3, 2026
@sharad-elastic
sharad-elastic marked this pull request as ready for review September 7, 2026 08:10
@sharad-elastic
sharad-elastic requested review from a team as code owners September 7, 2026 08:10
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@vera-review-bot

Copy link
Copy Markdown
Contributor

🟢 No issues across the latest commits 49895d8.

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot - v0.3.0 | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @sharad-elastic

@mergify

mergify Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@sharad-elastic
sharad-elastic merged commit 120560e into elastic:main Sep 11, 2026
10 checks passed
@sharad-elastic
sharad-elastic deleted the 1password-add-dataset-filter branch September 11, 2026 10:30
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package 1password - 1.39.2 containing this change is available at https://epr.elastic.co/package/1password/1.39.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:1password 1Password Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1Password]: Dashboard panel does not contain filter for dataset

2 participants

⌂ 换网址