Skip to content

New package - 1Password Events Reporting - #1722

Merged
P1llus merged 4 commits into
elastic:masterfrom
1Password:1password-package
Oct 19, 2021
Merged

P1llus merged 4 commits into
elastic:masterfrom
1Password:1password-package

Conversation

@ogero

@ogero ogero commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Create a new package to collect logs from 1Password Events Reporting.
There are two log data streams:

  • Item Usages - Uses the 1Password Events API to retrieve information about items in shared vaults that have been modified, accessed, or used.
  • Sign-in Attempts - Uses the 1Password Events API to retrieve information about sign-in attempts.

Closes elastic#1232

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Screenshots

1Password Sign-in Attempts

1Password Item Usages

1Password Events Reporting Elastic package

@cla-checker-service

cla-checker-service Bot commented Sep 14, 2021 •

Copy link
Copy Markdown

💚 CLA has been signed

@elasticmachine

elasticmachine commented Sep 14, 2021 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-18T20:22:38.775+0000

  • Duration: 14 min 50 sec

  • Commit: 529c8ec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Create a new package to collect logs from 1Password Events Reporting.
There are two log data streams:

- Item Usages - Uses the 1Password Events API to retrieve information about items in shared vaults that have been modified, accessed, or used.
- Sign-in Attempts - Uses the 1Password Events API to retrieve information about sign-in attempts.

Closes elastic#1232
description: i.e. certificate_authorities, supported_protocols, verification_mode etc.
multi: false
required: false
show_user: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the proxy config

      - name: proxy_url
        type: text
        title: Proxy URL
        multi: false
        required: false
        show_user: false
        description: URL to proxy connections in the form of http[s]://<user>:<password>@<server name/ip>:<port>

{{#if ssl}}
request.ssl: {{ssl}}
{{/if}}
request.transforms:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Proxy config

{{#if proxy_url }}
request.proxy_url: {{proxy_url}}
{{/if}}

@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds jamiehynds added New Integration Issue or pull request for creating a new integration package. Category: Password Vault labels Sep 16, 2021
@P1llus

P1llus commented Sep 16, 2021

Copy link
Copy Markdown
Member

Hello @ogero!
Thanks for the PR, happy to see it coming along :)

Would you mind signing the CLA posted in the comments with the email used in your commits/on your github account? Then I will start the CI and the review process afterwards.

@P1llus

P1llus commented Sep 16, 2021

Copy link
Copy Markdown
Member

/test

@ogero

ogero commented Sep 16, 2021

Copy link
Copy Markdown
Contributor Author

Hello @ogero!
Thanks for the PR, happy to see it coming along :)

Would you mind signing the CLA posted in the comments with the email used in your commits/on your github account? Then I will start the CI and the review process afterwards.

Hi @P1llus, thanks! I've requested 1Password to proceed with the CLA signature for the process to continue.

@ogero

ogero commented Oct 6, 2021

Copy link
Copy Markdown
Contributor Author

/test

@P1llus

P1llus commented Oct 6, 2021

Copy link
Copy Markdown
Member

Thanks for signing the CLA. I will try to get this through in the upcoming week! :)

@P1llus

P1llus commented Oct 13, 2021

Copy link
Copy Markdown
Member

@ogero Would it be possible to give us access to allow commits to the PR? Currently this is denied :(

I might need to add some small changes to it before approving it

@ogero

ogero commented Oct 13, 2021

Copy link
Copy Markdown
Contributor Author

Sure @P1llus! I've just sent the invite

@P1llus

P1llus commented Oct 13, 2021

Copy link
Copy Markdown
Member

We did a discussion earlier where I did the review, will await the changes to be pushed.

@ogero
ogero force-pushed the 1password-package branch from 3f9b471 to 529c8ec Compare October 15, 2021 14:19
@ogero

ogero commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

/test

1 similar comment
@P1llus

P1llus commented Oct 18, 2021

Copy link
Copy Markdown
Member

/test

@P1llus P1llus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might want to move the brackets of the dashboard name to start before the title, but except that we can merge now and update it in a separate PR.

@P1llus
P1llus merged commit f1410f9 into elastic:master Oct 19, 2021
@P1llus

P1llus commented Oct 19, 2021 •

Copy link
Copy Markdown
Member

Very much appreciate the pull request @ogero :) It will be a great addition! I have noted down that we might want to update the dashboard title in a separate PR, but the integration itself works well!
Will just have to check in which format we would like all the titles to be.

@ogero

ogero commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

🎉 Thanks for the great feedback.

@elastic elastic deleted a comment Jul 18, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* New package - 1Password Events Reporting

Create a new package to collect logs from 1Password Events Reporting.
There are two log data streams:

- Item Usages - Uses the 1Password Events API to retrieve information about items in shared vaults that have been modified, accessed, or used.
- Sign-in Attempts - Uses the 1Password Events API to retrieve information about sign-in attempts.

Closes elastic#1232

* Add Proxy config

* Address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Password Vault New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1Password

5 participants

⌂ 换网址