Repository navigation
New package - 1Password Events Reporting - #1722
Conversation
|
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Create a new package to collect logs from 1Password Events Reporting. There are two log data streams: - Item Usages - Uses the 1Password Events API to retrieve information about items in shared vaults that have been modified, accessed, or used. - Sign-in Attempts - Uses the 1Password Events API to retrieve information about sign-in attempts. Closes elastic#1232
f4efc58 to
594a1ca
Compare
| description: i.e. certificate_authorities, supported_protocols, verification_mode etc. | ||
| multi: false | ||
| required: false | ||
| show_user: false |
There was a problem hiding this comment.
Add the proxy config
- name: proxy_url
type: text
title: Proxy URL
multi: false
required: false
show_user: false
description: URL to proxy connections in the form of http[s]://<user>:<password>@<server name/ip>:<port>
| {{#if ssl}} | ||
| request.ssl: {{ssl}} | ||
| {{/if}} | ||
| request.transforms: |
There was a problem hiding this comment.
Add Proxy config
{{#if proxy_url }}
request.proxy_url: {{proxy_url}}
{{/if}}
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Hello @ogero! Would you mind signing the CLA posted in the comments with the email used in your commits/on your github account? Then I will start the CI and the review process afterwards. |
|
/test |
Hi @P1llus, thanks! I've requested 1Password to proceed with the CLA signature for the process to continue. |
|
/test |
|
Thanks for signing the CLA. I will try to get this through in the upcoming week! :) |
|
@ogero Would it be possible to give us access to allow commits to the PR? Currently this is denied :( I might need to add some small changes to it before approving it |
|
Sure @P1llus! I've just sent the invite |
|
We did a discussion earlier where I did the review, will await the changes to be pushed. |
3f9b471 to
529c8ec
Compare
|
/test |
1 similar comment
|
/test |
P1llus
left a comment
There was a problem hiding this comment.
LGTM. We might want to move the brackets of the dashboard name to start before the title, but except that we can merge now and update it in a separate PR.
|
Very much appreciate the pull request @ogero :) It will be a great addition! I have noted down that we might want to update the dashboard title in a separate PR, but the integration itself works well! |
|
🎉 Thanks for the great feedback. |
* New package - 1Password Events Reporting Create a new package to collect logs from 1Password Events Reporting. There are two log data streams: - Item Usages - Uses the 1Password Events API to retrieve information about items in shared vaults that have been modified, accessed, or used. - Sign-in Attempts - Uses the 1Password Events API to retrieve information about sign-in attempts. Closes elastic#1232 * Add Proxy config * Address feedback
What does this PR do?
Create a new package to collect logs from 1Password Events Reporting.
There are two log data streams:
Closes elastic#1232
Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).Screenshots