Skip to content

Change AWS default credential option to access keys - #1320

Merged
kaiyan-sheng merged 3 commits into
elastic:masterfrom
kaiyan-sheng:change_cred_options
Jul 13, 2021
Merged

kaiyan-sheng merged 3 commits into
elastic:masterfrom
kaiyan-sheng:change_cred_options

Conversation

@kaiyan-sheng

@kaiyan-sheng kaiyan-sheng commented Jul 12, 2021 •

Copy link
Copy Markdown

What does this PR do?

This PR changes AWS default credential option to access keys. When running on Docker, AWS credential file needs to be provided via volume mount and this is not shipped with elastic agent by default. Therefore, we should recommend users to use access key, secret access key and/or session token as default credential option.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Screenshots

Screen Shot 2021-07-12 at 8 12 37 AM

@kaiyan-sheng kaiyan-sheng self-assigned this Jul 12, 2021
@elasticmachine

elasticmachine commented Jul 12, 2021 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-13T14:24:46.584+0000

  • Duration: 15 min 30 sec

  • Commit: 9e617d6

Test stats 🧪

Test Results
Failed 0
Passed 247
Skipped 0
Total 247

Trends 🧪

Image of Build Times

Image of Tests

@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Jul 12, 2021
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

Comment thread packages/aws/changelog.yml Resolved
@kaiyan-sheng
kaiyan-sheng merged commit 49795ac into elastic:master Jul 13, 2021
@kaiyan-sheng
kaiyan-sheng deleted the change_cred_options branch July 13, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址