Skip to content

Change deprecation.elasticsearch keyword to elasticsearch.deprecation - #117933

Merged
JVerwolf merged 10 commits into
elastic:mainfrom
JVerwolf:enhancement/change-logging-field
Dec 4, 2024
Merged

JVerwolf merged 10 commits into
elastic:mainfrom
JVerwolf:enhancement/change-logging-field

Conversation

@JVerwolf

@JVerwolf JVerwolf commented Dec 3, 2024 •

Copy link
Copy Markdown
Contributor

This PR changes the values of the "data_stream.dataset" and "event.dataset" fields to be "elasticsearch.deprecation" instead of "deprecation.elasticsearch".

Closes #83251

@JVerwolf JVerwolf added >bug :Core/Infra/Logging Log management and logging utilities labels Dec 3, 2024
@JVerwolf
JVerwolf requested review from a team as code owners December 3, 2024 21:32
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.0.0 labels Dec 3, 2024
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Hi @JVerwolf, I've created a changelog YAML for you.

@rjernst rjernst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We just need to add some breaking change explanation.

pr: 117933
summary: Change `deprecation.elasticsearch` keyword to `elasticsearch.deprecation`
area: Infra/Logging
type: bug

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should note this as a breaking change, since some users may be relying on the ECS dataset.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjernst - I've updated it now, WDYT?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks more than just search, right? I've seen this in the logs of a cluster that someone had upgraded across versions:

[instance-0000000005] Bulk write of deprecation logs encountered some failures: [[4VK3j5UBamJ0EqvgUJmJ org.elasticsearch.index.mapper.DocumentParsingException: [1:87] failed to parse field [data_stream.dataset] of type [constant_keyword] in document with id '4VK3j5UBamJ0EqvgUJmJ'. Preview of field's value: 'elasticsearch.deprecation']]

So we're losing writes to the deprecation log until a rollover happens on the data stream.

@JVerwolf
JVerwolf requested a review from rjernst December 3, 2024 22:49

@rjernst rjernst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Hi @JVerwolf, I've updated the changelog YAML for you.

@JVerwolf
JVerwolf merged commit b716a53 into elastic:main Dec 4, 2024
rudolf added a commit to elastic/kibana that referenced this pull request Dec 18, 2024
…03418)

## Summary

Adapt UA test fixtures to be compatible with the upstream breaking
change elastic/elasticsearch#117933
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
…astic#203418)

## Summary

Adapt UA test fixtures to be compatible with the upstream breaking
change elastic/elasticsearch#117933
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…astic#203418)

## Summary

Adapt UA test fixtures to be compatible with the upstream breaking
change elastic/elasticsearch#117933
@leemthompo

Copy link
Copy Markdown
Member

@JVerwolf is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

@JVerwolf

Copy link
Copy Markdown
Contributor Author

@leemthompo Yup, I believe so. What am I missing here? Is there something else that needs to be included?

@leemthompo

Copy link
Copy Markdown
Member

@JVerwolf thanks for confirming! You're not missing anything, just collecting information to make sure we can eventually automatically populate a serverless changelog. Today we don't have a mechanism in our changelog yaml files for flagging whether or not a PR pertains to serverless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent value of event.dataset in ES deprecation logs

5 participants

⌂ 换网址