Repository navigation
Change deprecation.elasticsearch keyword to elasticsearch.deprecation - #117933
Conversation
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @JVerwolf, I've created a changelog YAML for you. |
…ent/change-logging-field
…f/elasticsearch into enhancement/change-logging-field
rjernst
left a comment
There was a problem hiding this comment.
Looks good. We just need to add some breaking change explanation.
| pr: 117933 | ||
| summary: Change `deprecation.elasticsearch` keyword to `elasticsearch.deprecation` | ||
| area: Infra/Logging | ||
| type: bug |
There was a problem hiding this comment.
We should note this as a breaking change, since some users may be relying on the ECS dataset.
There was a problem hiding this comment.
Thanks @rjernst - I've updated it now, WDYT?
There was a problem hiding this comment.
It breaks more than just search, right? I've seen this in the logs of a cluster that someone had upgraded across versions:
[instance-0000000005] Bulk write of deprecation logs encountered some failures: [[4VK3j5UBamJ0EqvgUJmJ org.elasticsearch.index.mapper.DocumentParsingException: [1:87] failed to parse field [data_stream.dataset] of type [constant_keyword] in document with id '4VK3j5UBamJ0EqvgUJmJ'. Preview of field's value: 'elasticsearch.deprecation']]
So we're losing writes to the deprecation log until a rollover happens on the data stream.
|
Hi @JVerwolf, I've updated the changelog YAML for you. |
…03418) ## Summary Adapt UA test fixtures to be compatible with the upstream breaking change elastic/elasticsearch#117933
…astic#203418) ## Summary Adapt UA test fixtures to be compatible with the upstream breaking change elastic/elasticsearch#117933
…astic#203418) ## Summary Adapt UA test fixtures to be compatible with the upstream breaking change elastic/elasticsearch#117933
|
@JVerwolf is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
|
@leemthompo Yup, I believe so. What am I missing here? Is there something else that needs to be included? |
|
@JVerwolf thanks for confirming! You're not missing anything, just collecting information to make sure we can eventually automatically populate a serverless changelog. Today we don't have a mechanism in our changelog yaml files for flagging whether or not a PR pertains to serverless. |
This PR changes the values of the
"data_stream.dataset"and"event.dataset"fields to be"elasticsearch.deprecation"instead of"deprecation.elasticsearch".Closes #83251