Repository navigation
Add option to skip older k8s events - #29396
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
|
This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
NOTE: |
|
Pinging @elastic/integrations (Team:Integrations) |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
| dedotConfig: dedotConfig, | ||
| watcher: watcher, | ||
| watchOptions: watchOptions, | ||
| skipOlder: true, |
There was a problem hiding this comment.
This value should come from the config like skipOlder: config.SkipOlder.
Now it is hardcoded to true.
There was a problem hiding this comment.
🤦🏼♂️ you are right! Thanks for catching this!
Signed-off-by: chrismark <chrismarkou92@gmail.com>
(cherry picked from commit 9b893e8) # Conflicts: # metricbeat/module/kubernetes/event/config.go
What does this PR do?
This PR adds option to skip older k8s events in
eventmetricset of kubernetes module.Why is it important?
There might be cases that
LastTimestampbeats/metricbeat/module/kubernetes/event/event.go
Lines 107 to 112 in a350c32
LastTimestampis not set.Related to #28923