Skip to content

Add ecs_logging to dependencies - #1840

Merged
basepi merged 3 commits into
elastic:mainfrom
basepi:ecs_logging
Jun 2, 2023
Merged

basepi merged 3 commits into
elastic:mainfrom
basepi:ecs_logging

Conversation

@basepi

@basepi basepi commented May 26, 2023

Copy link
Copy Markdown
Contributor

What does this pull request do?

Adds ecs_logging as a dependency, for easier log correlation setup.

Related issues

Ref #1837

@basepi
basepi requested a review from SylvainJuge June 1, 2023 19:05
@basepi
basepi merged commit 5f3df16 into elastic:main Jun 2, 2023
@sparrowt

Copy link
Copy Markdown

It seems odd for this to be a required dependency when in fact it is only needed if using an optional feature that is still marked as a 'technical preview' https://www.elastic.co/guide/en/apm/agent/python/current/configuration.html#config-log_ecs_reformatting

At least it doesn't have transient dependencies, but it feels strange to require everyone to install this just to use the main elastic apm agent, purely in order to make it easier for the minority to opt in to an extra feature.

Perhaps this could be an extra instead?

@xrmx

xrmx commented Nov 18, 2024

Copy link
Copy Markdown
Member

@sparrowt What does concern you about this dependency? I think that in this case the tradeoff is very much in favor of the convenience of having it always available instead of max efficiency with dependency size (I guess).

@sparrowt

sparrowt commented Dec 3, 2024

Copy link
Copy Markdown

I don't have any major concerns specifically about this dependency, but I guess my reasoning is a combination of:

  • being required to install unnecessary dependencies is generally undesirable, obviously build size can be a factor (sure it's small in this case but it all adds up), but also security patching required if a vuln were discovered, etc.
  • this feels very much an "optional extra" which seems like the perfect use case for the python packaging extras which many other packages use to avoid forcing everyone to install packages which are only needed for some optional sub-feature (this seems especially appropriate given things like "Note that this is a very blunt instrument that could have unintended side effects" here and it being designated as a 'technical preview')

P.S. typing lacks subtlety etc. so to be clear, please take this in a friendly way and it is not a super major blocker 😃 I'm just explaining the reasoning behind the question & generally many people (myself included) prefer not to add deps unless necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

⌂ 换网址