Repository navigation
Add ecs_logging to dependencies - #1840
Conversation
|
It seems odd for this to be a required dependency when in fact it is only needed if using an optional feature that is still marked as a 'technical preview' https://www.elastic.co/guide/en/apm/agent/python/current/configuration.html#config-log_ecs_reformatting At least it doesn't have transient dependencies, but it feels strange to require everyone to install this just to use the main elastic apm agent, purely in order to make it easier for the minority to opt in to an extra feature. Perhaps this could be an |
|
@sparrowt What does concern you about this dependency? I think that in this case the tradeoff is very much in favor of the convenience of having it always available instead of max efficiency with dependency size (I guess). |
|
I don't have any major concerns specifically about this dependency, but I guess my reasoning is a combination of:
P.S. typing lacks subtlety etc. so to be clear, please take this in a friendly way and it is not a super major blocker 😃 I'm just explaining the reasoning behind the question & generally many people (myself included) prefer not to add deps unless necessary. |
What does this pull request do?
Adds
ecs_loggingas a dependency, for easier log correlation setup.Related issues
Ref #1837