Skip to content

access headers directly - #1778

Merged
basepi merged 5 commits into
elastic:mainfrom
lioman:main
Mar 20, 2023
Merged

basepi merged 5 commits into
elastic:mainfrom
lioman:main

Conversation

@lioman

@lioman lioman commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

urllib3 deprecated getheader() method.

What does this pull request do?

Got some deprecation warnings, because elasticapm accesses deprecated getheader method.

urllib3 deprecated getheader() method.
@cla-checker-service

cla-checker-service Bot commented Mar 15, 2023 •

Copy link
Copy Markdown

💚 CLA has been signed

@github-actions github-actions Bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Mar 15, 2023
@basepi

basepi commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

I opened a PR against your PR: lioman#1

Note that if you open your PRs with a new branch (instead of using your main) it allows me to push these small changes directly to your open PR.

Thanks for signing the CLA! Once you merge my PR we can get this merged.

@basepi
basepi merged commit 795371c into elastic:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-python community Issues opened by the community triage Issues awaiting triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址