Skip to content

Lower log level for server version problems - #1692

Merged
basepi merged 2 commits into
elastic:mainfrom
basepi:fixup
Nov 17, 2022
Merged

basepi merged 2 commits into
elastic:mainfrom
basepi:fixup

Conversation

@basepi

@basepi basepi commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

What does this pull request do?

Currently our server version checks are fairly low stakes. If there are issues fetching the server version, we don't need to make them warning level. This sets them to debug.

I also added the request body to the JSON error case, as we ran into one of those recently and it was hard to debug since we didn't have the body in the logs.

@basepi

basepi commented Nov 14, 2022

Copy link
Copy Markdown
Contributor Author

As an aside, as we add more server version checks in the future we may need to re-evaluate this change. The current set of server version checks are pretty low-stakes, but that may not always be the case.

@ghost

ghost commented Nov 14, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-17T17:51:04.633+0000

  • Duration: 20 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 5075
Skipped 3470
Total 8545

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost

ghost commented Nov 14, 2022 •

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (230/230) 💚
Classes 100.0% (230/230) 💚
Lines 92.188% (18457/20021) 👍
Conditionals 75.231% (2855/3795) 👍

@beniwohli beniwohli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending updates to log levels in tests/transports/test_urllib3.py :D

@basepi
basepi merged commit 208e241 into elastic:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址