Skip to content

Fix missing return in opentelemetry.Span.is_recording - #1530

Merged
basepi merged 3 commits into
elastic:mainfrom
basepi:fixup
Apr 19, 2022
Merged

basepi merged 3 commits into
elastic:mainfrom
basepi:fixup

Conversation

@basepi

@basepi basepi commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

What does this pull request do?

Thanks to @trentm for spotting this while working on the Node implementation.

@basepi
basepi requested review from beniwohli and trentm April 19, 2022 17:03
@ghost

ghost commented Apr 19, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-19T17:31:58.431+0000

  • Duration: 21 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 4829
Skipped 3293
Total 8122

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@basepi basepi added this to the 8.3 milestone Apr 19, 2022
@basepi
basepi merged commit 9b3651d into elastic:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址