Skip to content

Add canonical MotionAware configuration validation - #1120

Merged
mariusmotea merged 3 commits into
diyhue:devfrom
YellowNest:pr/motionaware-config-foundation
Sep 9, 2026
Merged

mariusmotea merged 3 commits into
diyhue:devfrom
YellowNest:pr/motionaware-config-foundation

Conversation

@YellowNest

@YellowNest YellowNest commented Sep 8, 2026 •

Copy link
Copy Markdown

Summary

Adds a dependency-free, canonical MotionAware configuration layer with safe readers and legacy-key migration.

Scope

  • canonical motion_aware.areas persistence container
  • explicit migration from motionAware / motionaware
  • preserves valid False, 0, and empty values
  • validates health, resource references, and participants
  • malformed data becomes inert without crashing
  • packages the new module in the Docker image

Safety

No bridge identity, networking, certificates, production config, or Pro-specific personal data is included.

Validation

  • python3 -m unittest -v tests.test_motion_aware_config — 10 passed
  • Python syntax check for the new module and config loader
  • local Docker image build succeeded
  • import inside the built image: motionAwareConfig and configHandler succeeded
  • git diff --check upstream/dev...HEAD

The first CI run exposed a missing Dockerfile COPY; the follow-up commit fixes that packaging defect before merge.

@YellowNest

Copy link
Copy Markdown
Author

CI diagnosis: the PR does not modify .build/Dockerfile. The PR Build Test failure occurs in the existing image build before tests: curl: (77) error setting certificate file: /etc/ssl/certs/ca-certificates.crt, followed by /bin/sh: 1: pip3: not found. This is an upstream/base-image failure, not caused by the MotionAware files. The focused MotionAware tests pass locally (10/10).

@YellowNest

Copy link
Copy Markdown
Author

The shared CI build failure is addressed separately in PR #1127 (ca-certificates + python3 -m pip). Once merged, this PR should be rerun; MotionAware tests pass locally.

@YellowNest
YellowNest force-pushed the pr/motionaware-config-foundation branch from 073bed0 to 23c7be7 Compare September 9, 2026 06:26
@YellowNest

Copy link
Copy Markdown
Author

Updated after the first CI run: the new top-level module was not copied into the image. Commit e70859d adds the explicit Dockerfile COPY.

I reproduced the failure locally, rebuilt the image, and verified import motionAwareConfig together with configHandler inside the resulting container.

@YellowNest

Copy link
Copy Markdown
Author

Follow-up validation is complete for e70859d.

The Docker image checks now pass on every required target:

  • linux/amd64
  • linux/arm/v6
  • linux/arm/v7
  • linux/arm64

The follow-up commit only adds the top-level motionAwareConfig.py copy that
the first CI run proved was missing from the runtime image. No runtime
configuration, bridge identity, or local deployment data is included.

@mariusmotea
mariusmotea merged commit 75adb75 into diyhue:dev Sep 9, 2026
5 checks passed
@YellowNest
YellowNest deleted the pr/motionaware-config-foundation branch October 21, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址