Repository navigation
Conversation
Expose EvaluationMetricTurnType on metrics and custom config, and add ListModelEvaluationMetricsWithOptions so callers can filter by turn type without breaking the existing ListModelEvaluationMetrics(ctx) signature. Co-authored-by: Cursor <cursoragent@cursor.com>
achiang-do
force-pushed
the
feat/genai-evaluation-metric-turn-type
branch
from
October 23, 2026 03:53
d2d08c8 to
454cdbe
Compare
| ListModelEvaluationRuns(ctx context.Context, opt *ModelEvaluationRunListOptions) (*ModelEvaluationRunListResponse, *Response, error) | ||
| ListModelEvaluationPresets(ctx context.Context) (*ModelEvaluationPresetListResponse, *Response, error) | ||
| ListModelEvaluationMetrics(ctx context.Context) (*ModelEvaluationMetricListResponse, *Response, error) | ||
| ListModelEvaluationMetricsWithOptions(ctx context.Context, opt *ModelEvaluationMetricListOptions) (*ModelEvaluationMetricListResponse, *Response, error) |
Contributor
There was a problem hiding this comment.
Do we need 2 interfaces exposed ?
Can opt can be a variadic param ?
Contributor
Author
There was a problem hiding this comment.
We could make it variadic, but the pattern in godo seems to be to add an extra interface for WithOptions, like:
signals.go — ListConsents → ListConsentsWithOptions(ctx, opts *SignalsListConsentsOptions) (no-arg calls WithOptions(ctx, nil))
nfs.go — List → ListWithOptions(ctx, opts *NfsListOptions)
nfs.go — Delete → DeleteWithOptions(ctx, id, opts *NfsDeleteOptions)
ritheek-pitti-do
approved these changes
Nov 5, 2026
anup-deka
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to cthulhu#181229: expose GenAI custom/builtin evaluation metric
turn_typein godo so Go clients can create/list with single- vs multi-turn compatibility.EvaluationMetricTurnTypeenum (UNSPECIFIED/SINGLE_TURN/MULTI_TURN).TurnTypeonEvaluationMetricandCustomEvaluationMetricConfig(create/update send it via existingConfig; responses unmarshal it).ListModelEvaluationMetrics(ctx)unchanged (forwards withnil); addListModelEvaluationMetricsWithOptions(ctx, opt)withModelEvaluationMetricListOptions.TurnType→?turn_type=(same pattern asListConsents/ListConsentsWithOptions).Depends on the backend API having
turn_typedeployed (preview already verified).Not a breaking Go change: existing
ListModelEvaluationMetrics(ctx)callers keep compiling.Test plan
Unit Tests
-TestListModelEvaluationMetricsByTurnType makes sure client contract matches expectations
Manual Testing (Using Preview)
turn_typeturn_type=MULTI_TURNviaWithOptionsMULTI_TURN(builtins)uuid=81d452b6-…,turn_type=MULTI_TURNon metric + configPR Checklist
Submitter checklist
Proof of testing
Have you provided proof of testing for all logical paths in this change?
Reviewer checklist
WithOptionsadditive)Made with Cursor