Repository navigation
Fi 687 godo environment - #1185
Merged
SSharma-10 merged 7 commits intoOct 24, 2026
Merged
Conversation
Accept agent_id or environment_id on request helpers, always send agent_id on the wire, and decode both fields on responses.
Align consent/session path comments with the OpenAPI param name and lead dual-read mismatch errors with environment_id.
When neither AgentID nor EnvironmentID is set, nudge callers toward environment_id.
Resolve AgentID or EnvironmentID client-side, then emit environment_id so adoption metrics are not stuck on agent_id. Still accepts AgentID as a deprecated input alias.
aguan-hue
marked this pull request as ready for review
October 22, 2026 22:40
SSharma-10
approved these changes
Oct 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues work from #1182.
Changes it so that godo passes both EnvironmentID and AgentID to the APIs instead of setting one to the other. In addition removes the mismatch check, API was changed to handle this case so godo should receive an error from the APIs it calls rather than checking in the client.