Repository navigation
fix(FI-649): change SignalsDialogue.ID from int64 to string - #1184
Merged
SSharma-10 merged 1 commit intoOct 23, 2026
Merged
SSharma-10 merged 1 commit into
SSharma-10 merged 1 commit into
Conversation
The signals-api now returns dialogue id as a string-encoded UInt64 to avoid signed-overflow (values > 2^63-1 appeared negative) and JavaScript precision loss (values > 2^53). Changes: - SignalsDialogue.ID: int64 -> string - Updated TestSignals_ListSessionDialogues mock to return string id Fixes: FI-649
SSharma-10
approved these changes
Oct 23, 2026
sauravk-digitalocean
added a commit
to sauravk-digitalocean/doctl
that referenced
this pull request
Oct 23, 2026
Upgrade godo to v1.232.0 which changes SignalsDialogue.ID from int64 to string. The signals-api now returns dialogue id as a string-encoded UInt64 to avoid signed-overflow (values > 2^63-1 appeared negative) and JavaScript precision loss (values > 2^53). Changes: - go.mod: godo v1.230.0 -> v1.232.0 (via make upgrade_godo) - displayers/signals_session.go: use dl.ID directly (already string), remove unused strconv import - commands/signals_export_test.go: ID: 1 -> ID: "1" - do/signals_test.go: update mock JSON and assertion for string id Depends on: digitalocean/godo#1184 Fixes: FI-649
SSharma-10
pushed a commit
to digitalocean/doctl
that referenced
this pull request
Oct 23, 2026
Upgrade godo to v1.232.0 which changes SignalsDialogue.ID from int64 to string. The signals-api now returns dialogue id as a string-encoded UInt64 to avoid signed-overflow (values > 2^63-1 appeared negative) and JavaScript precision loss (values > 2^53). Changes: - go.mod: godo v1.230.0 -> v1.232.0 (via make upgrade_godo) - displayers/signals_session.go: use dl.ID directly (already string), remove unused strconv import - commands/signals_export_test.go: ID: 1 -> ID: "1" - do/signals_test.go: update mock JSON and assertion for string id Depends on: digitalocean/godo#1184 Fixes: FI-649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The signals-api now returns dialogue
idas a string-encoded UInt64 to avoid:UInt64values > 2^63−1 appeared as negative integers when serialised via Goint64.Changes
signals.goSignalsDialogue.ID:int64→stringsignals_test.goTestSignals_ListSessionDialoguesmock JSON to return stringidRelated
Testing
All existing tests pass (
go test ./...).