Skip to content

FI-688: --environment-id flag and EnvironmentID column - #2066

Merged
SSharma-10 merged 7 commits into
digitalocean:mainfrom
nhenning-do:fi-688-doctl-environment-id
Oct 27, 2026
Merged

SSharma-10 merged 7 commits into
digitalocean:mainfrom
nhenning-do:fi-688-doctl-environment-id

Conversation

@nhenning-do

Copy link
Copy Markdown
Contributor

Jira: https://do-internal.atlassian.net/browse/FI-688
Merge order: after the godo release. Swap the pseudo-version for the release tag before merge.

  • Add --environment-id alongside deprecated --agent-id on Signals commands; conflict when both differ; stderr warning when --agent-id is used
  • Add EnvironmentID display column with AgentID kept as a format alias; default output shows EnvironmentID
  • Pin godo to FI-687 commit via replace (fork) until the godo release lands
  • Tested: gofmt; go vet -mod=vendor ./...; go test -mod=vendor ./commands/ ./commands/displayers/ -count=1 -run Signals; go test -mod=vendor ./integration/ -count=1 -run 'TestRun/doctl/signals'

Prefer environment wording in consent command help, and bump the temporary godo replace to the FI-687 comment/mismatch polish commit.
@nhenning-do

Copy link
Copy Markdown
Contributor Author

Polish: consent help prefers environment wording; temporary godo replace bumped to FI-687 polish commit 7861f97 (still swap for release tag before merge).

Keep vendor/modules.txt in sync with the temporary godo replace bump.
Comment thread commands/signals_deletion.go Resolved
Match consent wording in list details, and pick up FI-687 client required-error polish.
Wording now says environment ID (environment only). Temporary godo replace picks up create/list sending environment_id.

@kjlee27 kjlee27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhenning-do
nhenning-do marked this pull request as ready for review October 26, 2026 20:35
@SSharma-10
SSharma-10 merged commit 9379c12 into digitalocean:main Oct 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址