Repository navigation
Conversation
6462157 to
461ddd5
Compare
| "Lists the public ingress URLs attached to a MicroVM, the system default URL included.", | ||
| Writer, aliasOpt("ls"), displayerType(&displayers.MicroVMURL{})) | ||
|
|
||
| cmdAdd := CmdBuilder(cmd, RunMicroVMURLAdd, "add <microvm-id>", |
There was a problem hiding this comment.
Getting 405 Method not allowed for this command
…(MDROP-596)
New: 'doctl compute microvm url {list,add,remove}' and '--ingress' on create (pass --ingress=false to skip the default URL). Wraps godo MicroVMsService.AddURL/RemoveURL and MicroVMCreateRequest.Ingress.
Co-authored-by: Cursor <cursoragent@cursor.com>
Pins github.com/digitalocean/godo to the merged commit dd8de92 (pseudo-version v1.229.1-0.20261019175741-dd8de92b0bd9), which adds MicroVMsService.AddURL/RemoveURL and MicroVMCreateRequest.Ingress. Re-pin to the next tagged godo release (>= v1.230.0) once it is cut. Co-authored-by: Cursor <cursoragent@cursor.com>
461ddd5 to
74eef4b
Compare
| github.com/blang/semver v3.5.1+incompatible | ||
| github.com/creack/pty v1.1.21 | ||
| github.com/digitalocean/godo v1.229.0 | ||
| github.com/digitalocean/godo v1.229.1-0.20261019175741-dd8de92b0bd9 |
There was a problem hiding this comment.
keep the version v1.229.0
There was a problem hiding this comment.
We can't stay on v1.229.0 for this PR — that tag is the parent of godo #1174 and does not include MicroVMsService.AddURL / RemoveURL or MicroVMCreateRequest.Ingress (confirmed against the v1.229.0 tree). Those APIs landed in dd8de92, which is one commit after v1.229.0 and is not in a tagged release yet.
So this PR has to pin the pseudo-version v1.229.1-0.20261019175741-dd8de92b0bd9 until the next godo tag that includes #1174 (expected >= v1.230.0). Happy to re-pin as soon as that release is cut.
There was a problem hiding this comment.
Updated — pinned to tagged godo v1.230.0 (includes #1174 via digitalocean/godo#1181).
Replaces the dd8de92 pseudo-version with the tagged release that includes godo digitalocean#1174 (AddURL/RemoveURL + create Ingress opt-out). Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Adds doctl support for MicroVM ingress URLs (MDROP-596):
doctl microvm creategains a--ingressflag (defaulttrue) to opt out of automatic ingress URL provisioning at create time.doctl microvm urlcommand group (aliasurls):list <microvm-id>— list a MicroVM's ingress URLs.add <microvm-id> --port <1-65535>— add an ingress URL for a port.remove <microvm-id> <url-id>— remove an ingress URL (--forceto skip confirmation).Implementation
do/microvms.go: service wrapper gainsAddURL/RemoveURL.commands/microvms.go: newurlsubcommand tree +--ingresscreate flag.commands/displayers/microvm.go:MicroVMURLdisplayer (ID, Hostname, Port, Default, Status).do/mocks/MicroVMsService.go: regenerated.Dependencies
Depends on godo MicroVM URL bindings (
MicroVMsService.AddURL/RemoveURL,MicroVMCreateRequest.Ingress) from digitalocean/godo#1174, included in tagged godo v1.230.0 (digitalocean/godo#1181).Proof of testing
Jira: https://do-internal.atlassian.net/browse/MDROP-596