Repository navigation
agents: explain why connections list omits revoked (MARSOHS-2175) - #2055
Merged
DO-rrao merged 2 commits intoOct 19, 2026
Merged
Conversation
connections list --status advertises active, pending and expired, but not revoked, which the API accepts. Tenant list reads always omit revoked connections, even when revoked is the filter (AR-2546), so the help now says that instead of advertising a filter that is always empty. Blast radius: doctl connections list --help text only; no behaviour change. Rollback: revert; no state is involved. MARSOHS-2175 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doctl harness-runtime connections list --statusadvertisesactive,pendingandexpired, but notrevoked, which the API accepts. Tenant list reads always omit revoked connections, even whenrevokedis the filter, so advertising it would point users at a filter that always returns an empty list. The help now keeps the three useful values and says that revoked connections are never listed.Jira: MARSOHS-2175
Scope
Blast radius
🟢 Services: doctl (
harness-runtime connections list --help) · Customers: none; every--statusvalue still goes to the API unchanged.Rollout
Decisions
revokedstays out of the advertised values, contrary to the ticket's first proposal: the tool-registry contract forListConnectionsRequest.statussays tenant list results omit revoked connections "including when this filter is revoked" (AR-2546).--status revoked, because that would copy server policy into the client and change behaviour for scripts.revokedis added back without pinning the sentence. (TestAgentConnectionsListStatusFlagUsage)Evidence
The new test failed on
main(usage did not mention revoked) and passes here; it also fails whenrevokedis added to the advertised values.make test_unitpasses exceptTestRegistryLogout, which fails the same way onmain. A local build against production returned rows foractive,pendingandexpired, an empty list forrevoked, and the API's 400 forbogus.🤖 Generated with Claude Code