Skip to content

agents: explain why connections list omits revoked (MARSOHS-2175) - #2055

Merged
DO-rrao merged 2 commits into
digitalocean:mainfrom
BadhriDO:marsohs-2175-connections-status-help
Oct 19, 2026
Merged

DO-rrao merged 2 commits into
digitalocean:mainfrom
BadhriDO:marsohs-2175-connections-status-help

Conversation

@BadhriDO

@BadhriDO BadhriDO commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

doctl harness-runtime connections list --status advertises active, pending and expired, but not revoked, which the API accepts. Tenant list reads always omit revoked connections, even when revoked is the filter, so advertising it would point users at a filter that always returns an empty list. The help now keeps the three useful values and says that revoked connections are never listed.
Jira: MARSOHS-2175

Scope

 doctl harness-runtime connections list
-  List the team's external-provider connections. Filter by `--actor` or `--status`.
+  List the team's external-provider connections. Filter by `--actor` or `--status`. Revoked connections are never listed.
   --status string
-      Filter by connection status (active|pending|expired)
+      Filter by connection status (active|pending|expired); revoked connections are never listed

Blast radius

🟢 Services: doctl (harness-runtime connections list --help) · Customers: none; every --status value still goes to the API unchanged.

Rollout

  • Rollback: revert; the change ships with the next doctl release and holds no state.

Decisions

  • revoked stays out of the advertised values, contrary to the ticket's first proposal: the tool-registry contract for ListConnectionsRequest.status says tenant list results omit revoked connections "including when this filter is revoked" (AR-2546).
  • doctl does not reject or warn on --status revoked, because that would copy server policy into the client and change behaviour for scripts.
  • The new test checks the advertised value set and the mention of revoked, not the exact wording, so it fails if revoked is added back without pinning the sentence. (TestAgentConnectionsListStatusFlagUsage)

Evidence

The new test failed on main (usage did not mention revoked) and passes here; it also fails when revoked is added to the advertised values. make test_unit passes except TestRegistryLogout, which fails the same way on main. A local build against production returned rows for active, pending and expired, an empty list for revoked, and the API's 400 for bogus.

🤖 Generated with Claude Code

BadhriDO and others added 2 commits October 19, 2026 01:59
connections list --status advertises active, pending and expired, but
not revoked, which the API accepts. Tenant list reads always omit
revoked connections, even when revoked is the filter (AR-2546), so the
help now says that instead of advertising a filter that is always empty.

Blast radius: doctl connections list --help text only; no behaviour
change.
Rollback: revert; no state is involved.

MARSOHS-2175

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@DO-rrao DO-rrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DO-rrao
DO-rrao merged commit 9f8bce1 into digitalocean:main Oct 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址