Skip to content

Remove EventFileValidation - #1579

Merged
mergify[bot] merged 1 commit into
masterfrom
remove-file-validation
Jun 11, 2019
Merged

mergify[bot] merged 1 commit into
masterfrom
remove-file-validation

Conversation

@cocreature

Copy link
Copy Markdown
Contributor

We never actually emit this event so it’s pretty much useless. If we
do want to add progress reporting at some point, we should go with the
recently added official support for that in LSP
microsoft/language-server-protocol#70 (comment).

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

We never actually emit this event so it’s pretty much useless. If we
do want to add progress reporting at some point, we should go with the
recently added official support for that in LSP
microsoft/language-server-protocol#70 (comment).

@neil-da neil-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@mergify
mergify Bot merged commit d9f266a into master Jun 11, 2019
@mergify
mergify Bot deleted the remove-file-validation branch June 11, 2019 09:15

@hurryabit hurryabit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

hsenag pushed a commit to hsenag/daml that referenced this pull request Sep 13, 2019
We never actually emit this event so it’s pretty much useless. If we
do want to add progress reporting at some point, we should go with the
recently added official support for that in LSP
microsoft/language-server-protocol#70 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址