Skip to content

Install all lockfile packages from the CI registry in Cloud Build tests - #2466

Open
mbiernacik wants to merge 1 commit into
mainfrom
ci-install-lockfile-from-ci-registry
Open

mbiernacik wants to merge 1 commit into
mainfrom
ci-install-lockfile-from-ci-registry

Conversation

@mbiernacik

Copy link
Copy Markdown
Contributor

Problem

Since #2458 moved lint and format checks to GitHub Actions, the Cloud Build tests no longer run pnpm install --frozen-lockfile from the CI registry: it was part of scripts/lint. Bazel (rules_js) only fetches the npm packages that the built targets need, so a lockfile with versions that aren't available in the CI registry can now pass the tests. The Lint job in GitHub Actions doesn't catch it either, since it installs from the public npm registry.
Example: #2452 adds fast-xml-builder@1.3.2 and is-unsafe@2.0.3, which aren't available in the CI registry yet.

Change

Run pnpm install --frozen-lockfile from the CI registry at the start of scripts/run_tests_on_cloudbuild again, before the unit and integration tests. It's the same command scripts/lint used to run there and takes a few seconds. Lint and format checks stay in GitHub Actions.

Testing

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址