Repository navigation
Install all lockfile packages from the CI registry in Cloud Build tests - #2466
Open
mbiernacik wants to merge 1 commit into
Open
mbiernacik wants to merge 1 commit into
mbiernacik wants to merge 1 commit into
Conversation
mbiernacik
requested review from
Ford544,
Pawbag123,
apilaskowski,
k-matuszek and
rafal-hawrylak
November 20, 2026 13:56
apilaskowski
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #2458 moved lint and format checks to GitHub Actions, the Cloud Build tests no longer run
pnpm install --frozen-lockfilefrom the CI registry: it was part ofscripts/lint. Bazel (rules_js) only fetches the npm packages that the built targets need, so a lockfile with versions that aren't available in the CI registry can now pass the tests. The Lint job in GitHub Actions doesn't catch it either, since it installs from the public npm registry.Example: #2452 adds
fast-xml-builder@1.3.2andis-unsafe@2.0.3, which aren't available in the CI registry yet.ERR_PNPM_FETCH_404 … fast-xml-builder-1.3.2.tgz.@google-cloud/storage→fast-xml-parser).Change
Run
pnpm install --frozen-lockfilefrom the CI registry at the start ofscripts/run_tests_on_cloudbuildagain, before the unit and integration tests. It's the same commandscripts/lintused to run there and takes a few seconds. Lint and format checks stay in GitHub Actions.Testing
scripts/lint, which ran in Cloud Build before ci: run lint and format checks in GitHub Actions #2458.fast-xml-builder@1.3.2until it is available in the CI registry. Other PRs are unaffected.