Skip to content

Split core/main_test.ts - #2301

Merged
Ford544 merged 1 commit into
mainfrom
core-main-test-split
Sep 11, 2026
Merged

Ford544 merged 1 commit into
mainfrom
core-main-test-split

Conversation

@Ford544

@Ford544 Ford544 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator
  • Split core/main_test.ts into several smaller files
  • Extract the writeDefinitionFile to testing dir

@Ford544
Ford544 requested a review from a team as a code owner September 11, 2026 07:51
@Ford544
Ford544 requested review from apilaskowski and zaptot and removed request for a team September 11, 2026 07:51
@Ford544
Ford544 added this pull request to stack #2303 September 11, 2026 10:38

@apilaskowski apilaskowski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring. Splitting up main_test.ts significantly improves readability and test maintenance. Nice catch converting the filenames with multiple dots cause compilation errors block to a proper test(...).

The PR description mentions extracting writeDefinitionFile, but writeWorkflowSettingsFile was also added (which was very helpful in cleaning up workflow_settings.yaml boilerplate).

@Ford544
Ford544 merged commit cd8f808 into main Sep 11, 2026
11 checks passed
@Ford544
Ford544 deleted the core-main-test-split branch September 11, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址