Repository navigation
Split core/main_test.ts - #2301
Merged
Merged
Conversation
Ford544
commented
Sep 11, 2026
Collaborator
- Split core/main_test.ts into several smaller files
- Extract the writeDefinitionFile to testing dir
Ford544
requested review from
apilaskowski and
zaptot
and removed request for
a team
September 11, 2026 07:51
apilaskowski
approved these changes
Sep 11, 2026
apilaskowski
left a comment
Collaborator
There was a problem hiding this comment.
Great refactoring. Splitting up main_test.ts significantly improves readability and test maintenance. Nice catch converting the filenames with multiple dots cause compilation errors block to a proper test(...).
The PR description mentions extracting writeDefinitionFile, but writeWorkflowSettingsFile was also added (which was very helpful in cleaning up workflow_settings.yaml boilerplate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.