Repository navigation
security: redact DSN from connection string parse errors - #48
Merged
Merged
Conversation
rahulcrl
force-pushed
the
fix/redact-dsn-from-errors
branch
from
July 21, 2026 08:57
9c79cbc to
bd57677
Compare
rahulcrl
force-pushed
the
fix/redact-dsn-from-errors
branch
2 times, most recently
from
July 21, 2026 09:03
501fa91 to
22913b4
Compare
pgxpool.ParseConfig and url.Parse can echo the raw connection URL in their errors, which may include an embedded password. Drop the upstream errors and return generic messages so credentials never reach stderr or logs.
rahulcrl
force-pushed
the
fix/redact-dsn-from-errors
branch
from
July 21, 2026 09:18
22913b4 to
a0a4f95
Compare
TheComputerM
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents credentials from leaking in error messages when the connection
string is malformed.
Changes
echo the raw DSN for keyword/value format connections) and return a
generic message
full DSN including password) and return a generic message
parse error output
URL validation error output