This repository was archived by the owner on May 20, 2025. It is now read-only.
Repository navigation
Restructure go packages - #37
Merged
Merged
Conversation
aramprice
marked this pull request as ready for review
July 24, 2024 18:40
... instead of assigning after instantiation.
- remove unused `VmdkPackageParameters.CopyFrom()` method
aramprice
force-pushed
the
restructure-go-packages
branch
from
July 26, 2024 18:35
d3c44e3 to
81d49d5
Compare
rajathagasthya
approved these changes
Jul 26, 2024
jpalermo
requested review from
a team,
nader-ziada and
xtreme-nitin-ravindran
and removed request for
a team
August 1, 2024 14:46
|
@aramprice , could you add a bit of context on the restructuring? |
Member
Author
|
@jpalermo - added context to the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ #36 is merged
The intent of these changes is to:
things.NewThing()sufficiesThese changes bring the code base closer to idiomatic go though there are still a lot of patterns which do not seem to be idiomatic Go.