Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

fixing melt model support for entities with no attributes due to inheritance - #368

Merged
pnickolov merged 1 commit into
cisco-open:mainfrom
rquedas:fxmodelattr
May 2, 2024
Merged

pnickolov merged 1 commit into
cisco-open:mainfrom
rquedas:fxmodelattr

Conversation

@rquedas

@rquedas rquedas commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Description

Added guard condition to support entities without attributes due to inheritance.

Type of Change

  • Bug Fix

@rquedas
rquedas requested a review from pnickolov as a code owner April 30, 2024 19:53
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 15.49%. Comparing base (00d0c6f) to head (0d11e21).
Report is 51 commits behind head on main.

Files Patch % Lines
cmd/melt/model.go 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #368       +/-   ##
===========================================
- Coverage   26.88%   15.49%   -11.39%     
===========================================
  Files          44      142       +98     
  Lines        4564    11370     +6806     
===========================================
+ Hits         1227     1762      +535     
- Misses       3242     9480     +6238     
- Partials       95      128       +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov
pnickolov merged commit 7d22f0d into cisco-open:main May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址