Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

Adding contenType optional flag to solution extend --add-metric - #366

Merged
pnickolov merged 4 commits into
cisco-open:mainfrom
rquedas:melthisto
May 3, 2024
Merged

pnickolov merged 4 commits into
cisco-open:mainfrom
rquedas:melthisto

Conversation

@rquedas

@rquedas rquedas commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Description

Allow developers to define what contentType a new metric should be and automatically set the proper category and aggregationTemporality attributes.

Supported contentTypes are:

  • sum
  • gauge
  • distribution
  • histogram

To use the new command:

fsoc solution extend --add-metric distmetric --contentType distribution

Type of Change

  • New Feature

@rquedas
rquedas requested a review from pnickolov as a code owner April 30, 2024 17:48
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 15.42%. Comparing base (00d0c6f) to head (8c2d922).
Report is 51 commits behind head on main.

Files Patch % Lines
platform/melt/exporter.go 0.00% 21 Missing ⚠️
platform/melt/types.go 0.00% 18 Missing ⚠️
cmd/solution/extend-fmm.go 0.00% 13 Missing ⚠️
cmd/solution/extend.go 0.00% 6 Missing ⚠️
cmd/melt/geometry-test.go 0.00% 5 Missing ⚠️
cmd/melt/send.go 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #366       +/-   ##
===========================================
- Coverage   26.88%   15.42%   -11.46%     
===========================================
  Files          44      142       +98     
  Lines        4564    11423     +6859     
===========================================
+ Hits         1227     1762      +535     
- Misses       3242     9533     +6291     
- Partials       95      128       +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov
pnickolov merged commit 1069dd4 into cisco-open:main May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址