This repository was archived by the owner on Nov 27, 2025. It is now read-only.
Repository navigation
Adding contenType optional flag to solution extend --add-metric - #366
Merged
Merged
Conversation
- adding --metric-type to solution extend --add-metric
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
===========================================
- Coverage 26.88% 15.42% -11.46%
===========================================
Files 44 142 +98
Lines 4564 11423 +6859
===========================================
+ Hits 1227 1762 +535
- Misses 3242 9533 +6291
- Partials 95 128 +33 ☔ View full report in Codecov by Sentry. |
pnickolov
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow developers to define what contentType a new metric should be and automatically set the proper category and aggregationTemporality attributes.
Supported contentTypes are:
To use the new command:
fsoc solution extend --add-metric distmetric --contentType distribution
Type of Change