Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

ORION-3224: use v2beta in path to ks apis and add support for references in fsoc ks get - #359

Merged
pnickolov merged 3 commits into
cisco-open:mainfrom
bemidji3:feature/master/ORION-3224
May 3, 2024
Merged

pnickolov merged 3 commits into
cisco-open:mainfrom
bemidji3:feature/master/ORION-3224

Conversation

@bemidji3

@bemidji3 bemidji3 commented Apr 22, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR contains changes to:

(1) use v2beta in the path to the knowledge store for requests made to the knowledge store (didn't touch any of the optimize command paths, however)
(2) add support for prefetchRefs and prefetchRefsInline query parameters when making get by ID requests (references is only support for get by id at this point)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bemidji3
bemidji3 requested a review from pnickolov as a code owner April 22, 2024 22:57
@codecov-commenter

codecov-commenter commented Apr 23, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 15.47%. Comparing base (00d0c6f) to head (3b676f0).
Report is 51 commits behind head on main.

Files Patch % Lines
cmd/knowledge/get.go 0.00% 19 Missing ⚠️
cmd/knowledge/knowledge.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #359       +/-   ##
===========================================
- Coverage   26.88%   15.47%   -11.42%     
===========================================
  Files          44      142       +98     
  Lines        4564    11388     +6824     
===========================================
+ Hits         1227     1762      +535     
- Misses       3242     9498     +6256     
- Partials       95      128       +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov
pnickolov merged commit f8df160 into cisco-open:main May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址