Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

Fixing issues with embedded references using yaml:,inline impacting f… - #348

Merged
pnickolov merged 1 commit into
cisco-open:mainfrom
rquedas:nestyaml
Apr 17, 2024
Merged

pnickolov merged 1 commit into
cisco-open:mainfrom
rquedas:nestyaml

Conversation

@rquedas

@rquedas rquedas commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

fsoc solution extend commands support for yaml object definitions

Description

The current implementation doesn't generate yaml object definitions properly given the usage of embedded type references, directly impacting fsoc solution extend commands and fsoc melt model.
The fix has been verified for fsoc solution extend command and fsoc melt model.

Type of Change

  • Bug Fix

Checklist

…soc solution extend commands support for yaml object definitions
@rquedas
rquedas requested a review from pnickolov as a code owner April 16, 2024 20:30
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 9.59%. Comparing base (00d0c6f) to head (b2993fe).
Report is 47 commits behind head on main.

Files Patch % Lines
cmd/solution/types.go 0.00% 27 Missing ⚠️
cmd/solution/extend.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #348       +/-   ##
==========================================
- Coverage   26.88%   9.59%   -17.30%     
==========================================
  Files          44     141       +97     
  Lines        4564   11345     +6781     
==========================================
- Hits         1227    1088      -139     
- Misses       3242   10183     +6941     
+ Partials       95      74       -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov
pnickolov merged commit c40b4d8 into cisco-open:main Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址