Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

ORION-3208: fix issue when tag not provided in fsoc solution status - #343

Merged
pnickolov merged 1 commit into
cisco-open:mainfrom
bemidji3:feature/main/ORION-3208
Apr 16, 2024
Merged

pnickolov merged 1 commit into
cisco-open:mainfrom
bemidji3:feature/main/ORION-3208

Conversation

@bemidji3

Copy link
Copy Markdown
Contributor

Description

Fixing minor issue with the fsoc solution status command when a user doesn't provide a tag for the solution using the command.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bemidji3
bemidji3 requested a review from pnickolov as a code owner April 11, 2024 03:49
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 10.17%. Comparing base (00d0c6f) to head (ebb7360).
Report is 41 commits behind head on main.

Files Patch % Lines
cmd/solution/status.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #343       +/-   ##
===========================================
- Coverage   26.88%   10.17%   -16.72%     
===========================================
  Files          44      137       +93     
  Lines        4564    10697     +6133     
===========================================
- Hits         1227     1088      -139     
- Misses       3242     9535     +6293     
+ Partials       95       74       -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov
pnickolov merged commit 905a240 into cisco-open:main Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址