Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

Proper support for fork + for from directory + solution show - #342

Merged
pnickolov merged 8 commits into
mainfrom
pn/newfork
Apr 16, 2024
Merged

pnickolov merged 8 commits into
mainfrom
pn/newfork

Conversation

@pnickolov

Copy link
Copy Markdown
Contributor

Description

Implemented a new internal object to read and keep in memory the full solution, with all its files.

Added solution show command that displays solution's elements: for now, list of files with annotation of their contents (e.g., knowledge vs. object, object type, etc.)

Added support for solution fork from a local directory, as this helps primers/tutorials/workshops and works around the restricted ability to download solutions from other tenants.

Modified the fork capability to not just do global replace (which can inadvertently replace more than necessary and break a solution); instead, it ensures that only values are changed (never keys) and only on word boundary. Additional exceptions are handled, such as renaming the namespace file (which is usually named after the solution name).

Retained the old fork capability for backward compatibility, under a --legacy-replace flag, in case the new algorithm doesn't take care of some cases that are covered in tutorials and workshops.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pnickolov
pnickolov marked this pull request as ready for review April 16, 2024 01:46
@pnickolov
pnickolov merged commit d8cc22b into main Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址