Repository navigation
fix: preserve context for rendering and report encoder errors - #788
Merged
Merged
Conversation
andrinoff
approved these changes
Sep 24, 2026
| out, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| log.Println(string(out)) | ||
| return fmt.Errorf("render failed: %w", err) |
Member
There was a problem hiding this comment.
Returning on the first failed encoder means if the GIF fails, the MP4/WebM/screenshots for the same tape are never attempted. Consider collecting the errors with errors.Join and running all commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #787.
Recording teardown canceled the context subsequently passed to ffmpeg, so completed tapes could exit successfully without creating their output. Keep recording cancellation on a child context and use the caller's context for rendering. Return encoder errors instead of only logging their output, so a missing ffmpeg executable or a failed render reaches the caller.
Added a regression test for missing ffmpeg and an opt-in browser test that records a short tape, decodes the resulting GIF, and checks cancellation immediately before rendering. All three cases failed on the original code and pass with the fix.
Validation on macOS arm64:
go test -race ./...go vet ./...VHS_TEST_BROWSER=1 go test -run 'Test(RenderMissingFFmpeg|EvaluateGIF)$' -count=1 -v .(real Chrome, ttyd and ffmpeg)Implemented with OpenAI Codex assistance and independently reviewed with Codex before submission.