Skip to content

feat: add viewport scroll commands to tapes - #707

Merged
aymanbagabas merged 2 commits into
charmbracelet:mainfrom
joshka-oai:joshka/scroll-commands-404
Mar 9, 2026
Merged

feat: add viewport scroll commands to tapes#707
aymanbagabas merged 2 commits into
charmbracelet:mainfrom
joshka-oai:joshka/scroll-commands-404

Conversation

@joshka-oai

@joshka-oai joshka-oai commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add ScrollUp and ScrollDown tape commands for viewport row scrolling
  • wire new commands through token lookup, parser command handling, and command execution via term.scrollLines()
  • update README/manual/demo fixture text and expand lexer/parser/command-count coverage

Rendered output

scroll smoke

Tape used:

Output "/tmp/scroll-smoke.gif"
Set Width 900
Set Height 500

Type "for i in $(seq 1 60); do echo line-$i; done"
Enter
Sleep 500ms

ScrollUp 12
Sleep 700ms
ScrollDown 6
Sleep 700ms

Testing

  • go test ./...

Fixes #404

@joshka-oai
feat: add viewport scroll commands to tapes
5bf9d1d 
Add ScrollUp and ScrollDown as first-class tape commands that scroll
the terminal viewport by rows, with optional @time and repeat count.
Wire them through token keywords, parser command types, and command
execution using term.scrollLines(+/-1).

Update docs and fixtures to include the new commands in README, manual,
demo comments, and all.tape. Expand lexer/parser coverage and command
count assertions for the new command surface.

Fixes charmbracelet#404
@joshka-oai
joshka-oai requested a review from a team as a code owner February 20, 2026 04:12
@joshka-oai
joshka-oai requested review from meowgorithm and raphamorim and removed request for a team February 20, 2026 04:12
@joshka-oai

joshka-oai commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

ping

raphamorim
raphamorim approved these changes Mar 5, 2026
View reviewed changes

@raphamorim raphamorim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overral looks good to me! thank you

@joshka-oai

joshka-oai commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Hi, I’m seeing approvals here, but no merge or release activity.

The failing checks also look unrelated to the actual change in this PR. I’d be happy to submit a small follow-up fix for those if that would help, but from the outside it also looks like this repo may no longer be actively maintained or released.

Could someone confirm whether this project is still being maintained, and whether PRs like this are still expected to land?

@aymanbagabas

aymanbagabas commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Hi @joshka-oai, thank you for your patience and contribution. We're looking into why the checks are failing, and will merge your PR very soon.

@aymanbagabas
aymanbagabas merged commit bae3eb0 into charmbracelet:main Mar 9, 2026
9 checks passed
@aymanbagabas

aymanbagabas commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Thank you @joshka-oai so much for your contribution!

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 8, 2026
ECG Bot Tyrone Meijn
build(deps): update vhs to v0.11.0
4f36bd5 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [vhs](https://github.com/charmbracelet/vhs) | minor | `0.10.0` → `0.11.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>charmbracelet/vhs (vhs)</summary>

### [`v0.11.0`](https://github.com/charmbracelet/vhs/releases/tag/v0.11.0)

[Compare Source](charmbracelet/vhs@v0.10.0...v0.11.0)

### Scroll? More keys?

This release includes two nice features that include scrolling the viewport and supporting `Ctrl+<arrow>` keys. You can now use the `ScrollUp` and `ScrollDown` commands to scroll the viewport. VHS will also now recognize `Ctrl+Left/Up/Right/Down` keys.

Thanks to [@&#8203;joshka-oai](https://github.com/joshka-oai) and [@&#8203;sectore](https://github.com/sectore) for their gracious contributions and support 🙂

#### Changelog

##### New!

- [`bae3eb0`](charmbracelet/vhs@bae3eb0): feat: add viewport scroll commands to tapes ([#&#8203;707](charmbracelet/vhs#707)) ([@&#8203;joshka-oai](https://github.com/joshka-oai))
- [`9e27976`](charmbracelet/vhs@9e27976): feat: support `ctrl` + arrow keys ([#&#8203;673](charmbracelet/vhs#673)) ([@&#8203;sectore](https://github.com/sectore))

##### Fixed

- [`55f824a`](charmbracelet/vhs@55f824a): fix(docker): remove ubuntu font which is no longer available in alpine ([@&#8203;aymanbagabas](https://github.com/aymanbagabas))
- [`b8a1d86`](charmbracelet/vhs@b8a1d86): fix(docker): update env variables to use '=' ([@&#8203;aymanbagabas](https://github.com/aymanbagabas))
- [`9c80359`](charmbracelet/vhs@9c80359): fix: lint issues ([@&#8203;aymanbagabas](https://github.com/aymanbagabas))

##### Other stuff

- [`9efc235`](charmbracelet/vhs@9efc235): Fix lexer regex escaping ([#&#8203;678](charmbracelet/vhs#678)) ([@&#8203;raphamorim](https://github.com/raphamorim))
- [`0a14d2c`](charmbracelet/vhs@0a14d2c): ci: sync dependabot config ([#&#8203;660](charmbracelet/vhs#660)) ([@&#8203;charmcli](https://github.com/charmcli))
- [`0bb2251`](charmbracelet/vhs@0bb2251): ci: sync dependabot config ([#&#8203;668](charmbracelet/vhs#668)) ([@&#8203;charmcli](https://github.com/charmcli))
- [`a94d725`](charmbracelet/vhs@a94d725): ci: sync golangci-lint config ([@&#8203;caarlos0](https://github.com/caarlos0))
- [`be49219`](charmbracelet/vhs@be49219): ci: sync golangci-lint config ([#&#8203;650](charmbracelet/vhs#650)) ([@&#8203;github-actions](https://github.com/github-actions)\[bot])

***

<details>
<summary>Verifying the artifacts</summary>

First, download the [`checksums.txt` file](https://github.com/charmbracelet/vhs/releases/download/v0.11.0/checksums.txt) and the [`checksums.txt.sigstore.json` file](https://github.com/charmbracelet/vhs/releases/download/v0.11.0/checksums.txt.sigstore.json) files, for example, with `wget`:

```bash
wget 'https://github.com/charmbracelet/vhs/releases/download/v0.11.0/checksums.txt'
wget 'https://github.com/charmbracelet/vhs/releases/download/v0.11.0/checksums.txt.sigstore.json'
```

Then, verify it using [`cosign`](https://github.com/sigstore/cosign):

```bash
cosign verify-blob \
  --certificate-identity 'https://github.com/charmbracelet/meta/.github/workflows/goreleaser.yml@refs/heads/main' \
  --certificate-oidc-issuer 'https://token.actions.githubusercontent.com' \
  --bundle 'checksums.txt.sigstore.json' \
  ./checksums.txt
```

If the output is `Verified OK`, you can safely use it to verify the checksums of other artifacts you downloaded from the release using `sha256sum`:

```bash
sha256sum --ignore-missing -c checksums.txt
```

Done! You artifacts are now verified!

</details>

<a href="https://charm.land/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-banner-next.jpg" width="400"></a>

Thoughts? Questions? We love hearing from you. Feel free to reach out on [X](https://x.com/charmcli), [Discord](https://charm.land/discord), [Slack](https://charm.land/slack), [The Fediverse](https://mastodon.social/@&#8203;charmcli), [Bluesky](https://bsky.app/profile/charm.land).

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNjguNSIsInVwZGF0ZWRJblZlciI6IjQzLjE2OC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm was automatically assigned from charmbracelet/everyone
2 more reviewers
@aymanbagabas aymanbagabas aymanbagabas approved these changes
@raphamorim raphamorim raphamorim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support scrolling the terminal

3 participants

@joshka-oai @aymanbagabas @raphamorim
⌂ 换网址