Repository navigation
fix: lint - #637
Merged
Merged
fix: lint#637
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes multiple lint issues across the codebase by updating file permissions, standardizing error message formatting, and improving package documentation comments.
- Updated os.MkdirAll permissions to 0o750 in several files for consistency.
- Replaced direct WriteString calls with fmt.Fprintf and standardized error message casing.
- Added package-level documentation comments and removed unused code.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| video.go, vhs.go, testing.go | Updated directory creation permissions to 0o750 for improved security style. |
| serve_unix.go, record.go, ffmpeg.go | Standardized error message and logging methods using fmt.Fprintf. |
| token/token.go, parser/parser.go, lexer/lexer.go, examples/* | Added or updated package comments to resolve lint warnings. |
| go.mod | Updated Go version to 1.24.1. |
| evaluator.go | Added a nolint suppression on staticcheck. |
| draw.go, command.go | Improved function documentation comments. |
Comments suppressed due to low confidence (1)
evaluator.go:79
- Consider adding an explanatory comment along with the nolint directive to clarify why staticcheck is being suppressed.
//nolint:staticcheck
aymanbagabas
approved these changes
Jun 17, 2025
andreynering
approved these changes
Jun 17, 2025
leosunmo
pushed a commit
to leosunmo/vhs
that referenced
this pull request
Oct 3, 2025
melMass
pushed a commit
to melMass/vhs
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a bunch of lint issues.