Repository navigation
docs: add "Enter" to cleanup example - #598
Merged
Merged
Conversation
raphamorim
approved these changes
Mar 12, 2025
raphamorim
left a comment
raphamorim
left a comment
Contributor
There was a problem hiding this comment.
Make sense to me, thanks for the PR!
leosunmo
pushed a commit
to leosunmo/vhs
that referenced
this pull request
Oct 3, 2025
melMass
pushed a commit
to melMass/vhs
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all,
Big fan of VHS (and Charm in general)!
Wanted to propose a small change to the "Cleanup" example.
I was scratching my head trying to figure out why my tape wasn't actually deleting the file, then realized it was missing the "Enter", so I thought it was worth clarifying in the readme.