Repository navigation
fix(record): propagate env of vhs process to record terminal - #572
Merged
Merged
Conversation
Contributor
Author
|
It looks like lint issues are unrelated to my change, so I don't think I need to fix them. |
Contributor
|
@tr3mor agreed, will take a look at this. Thanks so much for spotting this issue and coming up with a solution |
|
Can we get this merged? Currently vhs is hardly usable without env inheritance and requires extra steps to init even simple PATH variable. |
caarlos0
approved these changes
Mar 10, 2025
Contributor
|
I think this makes sense, yes. |
|
Any idea when this version will be released with the fix? Thanks in advance! |
leosunmo
pushed a commit
to leosunmo/vhs
that referenced
this pull request
Oct 3, 2025
melMass
pushed a commit
to melMass/vhs
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This pr broke env variables propagation to terminal spawned by record command.
From Env description
Appending
VHS_RECORDmakes it not nil, so it resets env. This pr fixes #554.For example with the latest released vhs
The simplest solution is to get env of the main process and then append
VHS_RECORDThe same example with the build from this PR
Let me know if you see a better solution.