Skip to content

fix(record): set PAGEX to PAGE_X for proper capitalization - #570

Merged
caarlos0 merged 4 commits into
mainfrom
fix-pageup-record
Mar 19, 2025
Merged

caarlos0 merged 4 commits into
mainfrom
fix-pageup-record

Conversation

@bashbunni

Copy link
Copy Markdown
Contributor

PAGEUP and PAGEDOWN weren't applying camel case correctly due to the lack of separation between its parts. Now it uses snake case to ensure proper casing of the vhs command.

PAGEUP -> PAGE_UP; same for PAGEDOWN

Fixes #559

@bashbunni bashbunni added the bug Something isn't working label Jan 15, 2025
@bashbunni
bashbunni requested a review from a team as a code owner March 18, 2025 16:13
@bashbunni
bashbunni requested review from raphamorim and removed request for a team March 18, 2025 16:13
@caarlos0
caarlos0 merged commit ed7c8a9 into main Mar 19, 2025
@caarlos0
caarlos0 deleted the fix-pageup-record branch March 19, 2025 12:10
leosunmo added a commit to leosunmo/vhs that referenced this pull request Oct 3, 2025
…elet#570)

* fix(record): set PAGEX to PAGE_X for proper capitalization

* chore: fix lint + formatting

* chore(lint): add lint ignore for snake case
melMass pushed a commit to melMass/vhs that referenced this pull request Nov 17, 2025
…elet#570)

* fix(record): set PAGEX to PAGE_X for proper capitalization

* chore: fix lint + formatting

* chore(lint): add lint ignore for snake case
leosunmo added a commit to leosunmo/vhs that referenced this pull request Jul 3, 2026
…elet#570)

* fix(record): set PAGEX to PAGE_X for proper capitalization

* chore: fix lint + formatting

* chore(lint): add lint ignore for snake case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vhs record generates invalid tapes when used PageUp/Down is repeatedly pressed

2 participants

⌂ 换网址