Repository navigation
fix: source - #567
Merged
Merged
fix: source#567
Conversation
rsteube
marked this pull request as ready for review
January 4, 2025 23:25
Contributor
|
does this do the same as #551 ? |
Contributor
Author
|
Oh, didn't see that one. I think so, but let me see. This one is a bit tricky, so better have a closer look. |
caarlos0
approved these changes
Mar 26, 2025
caarlos0
left a comment
caarlos0
left a comment
Contributor
There was a problem hiding this comment.
just tested it, seems to work! thanks for the pr!
i have one small remark only :)
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
raphamorim
approved these changes
Mar 26, 2025
bashbunni
approved these changes
Mar 26, 2025
bashbunni
left a comment
bashbunni
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thank you!
Contributor
|
see also #604 |
leosunmo
added a commit
to leosunmo/vhs
that referenced
this pull request
Oct 3, 2025
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
melMass
pushed a commit
to melMass/vhs
that referenced
this pull request
Nov 17, 2025
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the parsed
Sourcecommand instead of re-parsing it later.Works for me so far, but not sure if this is the right approach.
fix #566